HLP Network

News:

HLP Donations Page has been reworked for supporting the site.
Please note that the previous "Tiers" are currently not operational (but will be worked on).
You can still cancel any previous re-occurring donations to make new ones which will go to the new Treasurer Admin (Zacam).

 
« Previous Thread Next Thread »
Print
Pages: [1]   Go Down

Author Topic: what macro?  (Read 4021 times)

0 Members and 1 Guest are viewing this topic.

Offline asyikarea51

  • 210
  • -__-||
what macro?
on: May 19, 2009, 10:48:20 am
It's quite obvious that the build I'm using is old in terms of bleeding-edge... even though I don't really need something so "new" in practice... :lol:

Code: [Select]
--------------------Configuration: code - Win32 Release--------------------
Performing Custom Build Step on ..\..\code\sound\phrases.xml
Compilation successful!
Compilation successful!
Compiling...
ai.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
AiBig.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
AiCode.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
AiGoals.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
MissionBriefCommon.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
Chatbox.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
MissionBrief.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
MissionCmdBrief.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
MissionDebrief.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
MissionPause.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
MissionRecommend.cpp
MissionScreenCommon.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
MissionShipChoice.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
MissionWeaponChoice.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
RedAlert.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
Afterburner.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
AWACS.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
Shield.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
Ship.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
F:\FS_Open\FSOcode\code\ship\Ship.cpp(3859) : warning C4002: too many actual parameters for macro 'Assertion'
ShipContrails.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
ShipFX.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
ShipHit.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
NebLightning.cpp
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: '.' : unexpected in macro formal parameter list
../../code\globalincs/pstypes.h(639) : error C2010: ')' : unexpected in macro formal parameter list
Error executing cl.exe.

fs2_open_trunk_r.exe - 88 error(s), 1 warning(s)
:confused:
 

Offline portej05

  • 29
Re: what macro?
Reply #1 on: May 19, 2009, 10:55:04 am
We need a little more information to figure out what's going on.
The macro on line 639 of pstypes is a variadic Assertion macro (in my checkout - but that was done today)

Can you tell us:
1) Which revision of pstypes.h you're using
2) Which compiler you're using (it looks like VC, but I don't know which version)
3) What type of compile you're trying to do (compile defines/flags)
STRONGTEA. Why can't the x86 be sane?
 

Offline asyikarea51

  • 210
  • -__-||
Re: what macro?
Reply #2 on: May 19, 2009, 11:03:28 am
1. Not sure. I just updated the code I have here from SVN, like 15 minutes ago. How do I check it?
In case it matters the last stable build I managed to compile could be anywhere from r5165 and below...
2. VC6
3. FreeSpace2 Win32 Release

Another one courtesy of VC2005... :lol:

Code: [Select]
4>Generating Code...
4>Compiling resources...
4>Linking...
4>code.lib(MissionGoals.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_sexp_flush_packet(void)" (?multi_sexp_flush_packet@@YAXXZ) referenced in function "void __cdecl mission_eval_goals(void)" (?mission_eval_goals@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "bool __cdecl multi_get_ship(struct ship * &)" (?multi_get_ship@@YA_NAAPAUship@@@Z) referenced in function "void __cdecl multi_sexp_set_energy_pct(void)" (?multi_sexp_set_energy_pct@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "bool __cdecl multi_get_float(float &)" (?multi_get_float@@YA_NAAM@Z) referenced in function "void __cdecl multi_sexp_set_energy_pct(void)" (?multi_sexp_set_energy_pct@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "int __cdecl multi_sexp_get_operator(void)" (?multi_sexp_get_operator@@YAHXZ) referenced in function "void __cdecl multi_sexp_set_energy_pct(void)" (?multi_sexp_set_energy_pct@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "bool __cdecl multi_get_string(char *)" (?multi_get_string@@YA_NPAD@Z) referenced in function "void __cdecl multi_sexp_change_soundtrack(void)" (?multi_sexp_change_soundtrack@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_end_packet(void)" (?multi_end_packet@@YAXXZ) referenced in function "void __cdecl sexp_play_sound_from_table(int)" (?sexp_play_sound_from_table@@YAXH@Z)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_send_int(int)" (?multi_send_int@@YAXH@Z) referenced in function "void __cdecl sexp_play_sound_from_table(int)" (?sexp_play_sound_from_table@@YAXH@Z)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_send_float(float)" (?multi_send_float@@YAXM@Z) referenced in function "void __cdecl sexp_play_sound_from_table(int)" (?sexp_play_sound_from_table@@YAXH@Z)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_start_packet(void)" (?multi_start_packet@@YAXXZ) referenced in function "void __cdecl sexp_play_sound_from_table(int)" (?sexp_play_sound_from_table@@YAXH@Z)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "bool __cdecl multi_get_int(int &)" (?multi_get_int@@YA_NAAH@Z) referenced in function "void __cdecl multi_sexp_play_sound_from_table(void)" (?multi_sexp_play_sound_from_table@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "bool __cdecl multi_get_bool(bool &)" (?multi_get_bool@@YA_NAA_N@Z) referenced in function "void __cdecl multi_sexp_close_sound_from_file(void)" (?multi_sexp_close_sound_from_file@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "bool __cdecl multi_get_parse_object(struct p_object * &)" (?multi_get_parse_object@@YA_NAAPAUp_object@@@Z) referenced in function "void __cdecl multi_sexp_deal_with_ship_flag(void)" (?multi_sexp_deal_with_ship_flag@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "bool __cdecl multi_get_ship(int &)" (?multi_get_ship@@YA_NAAH@Z) referenced in function "void __cdecl multi_sexp_change_ship_class(void)" (?multi_sexp_change_ship_class@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_send_string(char *)" (?multi_send_string@@YAXPAD@Z) referenced in function "void __cdecl sexp_modify_variable(char *,int,bool)" (?sexp_modify_variable@@YAXPADH_N@Z)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_send_bool(bool)" (?multi_send_bool@@YAX_N@Z) referenced in function "void __cdecl sexp_close_sound_from_file(int)" (?sexp_close_sound_from_file@@YAXH@Z)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "bool __cdecl multi_sexp_discard_operator(void)" (?multi_sexp_discard_operator@@YA_NXZ) referenced in function "void __cdecl multi_sexp_eval(void)" (?multi_sexp_eval@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "int __cdecl multi_sexp_get_next_operator(void)" (?multi_sexp_get_next_operator@@YAHXZ) referenced in function "void __cdecl multi_sexp_eval(void)" (?multi_sexp_eval@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2001: unresolved external symbol "int Multi_sexp_bytes_left" (?Multi_sexp_bytes_left@@3HA)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl initalise_sexp_packet(void)" (?initalise_sexp_packet@@YAXXZ) referenced in function "void __cdecl init_sexp(void)" (?init_sexp@@YAXXZ)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_send_ship(struct ship *)" (?multi_send_ship@@YAXPAUship@@@Z) referenced in function "void __cdecl sexp_set_energy_pct(int,int)" (?sexp_set_energy_pct@@YAXHH@Z)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_send_parse_object(struct p_object *)" (?multi_send_parse_object@@YAXPAUp_object@@@Z) referenced in function "void __cdecl sexp_deal_with_ship_flag(int,int,int,int,int,int,int,int,bool,bool)" (?sexp_deal_with_ship_flag@@YAXHHHHHHHH_N0@Z)
4>code.lib(SEXP.obj) : error LNK2019: unresolved external symbol "void __cdecl multi_send_ship(int)" (?multi_send_ship@@YAXH@Z) referenced in function "void __cdecl sexp_deal_with_ship_flag(int,int,int,int,int,int,int,int,bool,bool)" (?sexp_deal_with_ship_flag@@YAXHHHHHHHH_N0@Z)
4>code.lib(MultiMsgs.obj) : error LNK2019: unresolved external symbol "void __cdecl sexp_packet_received(unsigned char *,int)" (?sexp_packet_received@@YAXPAEH@Z) referenced in function "void __cdecl process_sexp_packet(unsigned char *,struct header *)" (?process_sexp_packet@@YAXPAEPAUheader@@@Z)
4>(directory)\fs2_open_3_6_10r.exe : fatal error LNK1120: 23 unresolved externals
4>Creating browse information file...
4>Microsoft Browse Information Maintenance Utility Version 8.00.50727
4>Copyright (C) Microsoft Corporation. All rights reserved.
4>Build log was saved at "file://(directory)\BuildLog.htm"
4>Freespace2 - 24 error(s), 0 warning(s)
========== Build: 3 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
 

Offline portej05

  • 29
Re: what macro?
Reply #3 on: May 19, 2009, 11:07:32 am
Are you opening the project file from Projects/MSVC_*? I haven't had a problem using those
Also, are you using VC2005 or VC6?
STRONGTEA. Why can't the x86 be sane?
 

Offline asyikarea51

  • 210
  • -__-||
Re: what macro?
Reply #4 on: May 19, 2009, 11:14:08 am
yes, Projects/MSVC_*

I more-or-less am able to use both. The error in the first post was me trying to compile with VC6.
The second one with VC2005 (I just had to try it to see if it got anywhere, sorry if I went off track a little XD).

For VC6 I'm using the older project file (not Chief's one) since I'd already put the speech SDK files in some mysterious place I can't find now... and normally when VC asks to save changes to the project because of the speech flag I usually click "no"...
 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: what macro?
Reply #5 on: May 19, 2009, 01:16:26 pm
There's been some recent commits of new files that might not have been added to all the main project files yet, bear with us for a bit.  I don't think either of the VC6 projects were updated yet but the 2008 one should have been.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays
 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: what macro?
Reply #6 on: May 19, 2009, 01:23:12 pm
Yeah, I mentioned this when I merged my code. The 2005 and VC6 code project files have no mention of network/multi_sexp.h and .cpp and the FRED project file needs to have altshipclassdlg.h and .cpp added.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]
 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: what macro?
Reply #7 on: May 19, 2009, 03:44:08 pm
I will probably update the trunk VC6 projects about the time I work on the RC3 builds (unrelated really but I'll be in VC6 at the time).  Unless someone can beat me to it.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays
 

Offline asyikarea51

  • 210
  • -__-||
Re: what macro?
Reply #8 on: May 20, 2009, 03:43:12 am
Haaaah, didn't know kara uses VS2008 now.

Well then guess it's time to settle my own networking wtf's before I temporarily shift all code compiling to the alternate computer... it has VS2008 (blame education :lol:) but I have yet to compile anything with it, let alone type any code on it... heck try working on an IDE without an SDK~ XD

But yeah I'm okay with being patient :) I did read one or two SVN logs about 3.6.11 and whatnot so all the more reason I shouldn't be disturbing you guys... :nervous:


EDIT: random n00bie question: are the two errors related? or two totally different ones which pretty much have to do with the compiler and/or IDE? :)
« Last Edit: May 20, 2009, 03:51:20 am by asyikarea51 »
 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: what macro?
Reply #9 on: May 20, 2009, 04:15:22 am
They both seem to relate to my commits but I can't understand what is causing the first one. It does seem to be related to my Assertion code though. Not entirely sure how though.

The 2005 errors however are very easy to fix. Open up VC2005, load the project file, click on the code\network folder and choose Add->Existing item. A requester opens up, find the multi_sexp.cpp and .h file and select them. Problem solved.

You'll have to do something similar to add the other files I mentioned earlier that FRED needs but that should be enough to build FS2_Open.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]
 

Offline portej05

  • 29
Re: what macro?
Reply #10 on: May 20, 2009, 04:44:36 am
From MSDN
Quote
Support for variadic macros was introduced in Visual C++ 2005.

(@line 637 of pstypes.h)
Code: [Select]
#if defined(NDEBUG)
#define Assert(x) do {} while (0)
#define Assertion(x, y, ...) do {} while (0)
#else
void gr_activate(int);
#define Assert(x) do { if (!(x)){ WinAssert(#x,__FILE__,__LINE__); } } while (0)
#define Assertion(x, y, ...) do { if (!(x)){ WinAssert(#x,__FILE__,__LINE__, y, __VA_ARGS__ ); } } while (0)

#endif

If these call WinAssert, how is debugging done under other OSs?
« Last Edit: May 20, 2009, 04:48:26 am by portej05 »
STRONGTEA. Why can't the x86 be sane?
 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: what macro?
Reply #11 on: May 20, 2009, 05:07:40 am
Quote from: portej05 on May 20, 2009, 04:44:36 am
From MSDN
Quote
Support for variadic macros was introduced in Visual C++ 2005.

Well that's ****ing annoying.

Quote
If these call WinAssert, how is debugging done under other OSs?

windows_stub/stubs.cpp
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]
 

Offline portej05

  • 29
Re: what macro?
Reply #12 on: May 30, 2009, 10:56:22 am
Hey chief:
Your 5315 commit for this issue may not fix the problem!
The problem is that variadic macros aren't supported below VC2005, however they are supported in g++.
The code path that Assertion provides is only going to be hit on windows builds (currently, as far as I can tell), so anyone compiling a windows build with MinGW may actually get a compile error if more than two arguments are specified to Assertion at any point.
STRONGTEA. Why can't the x86 be sane?
 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: what macro?
Reply #13 on: May 30, 2009, 11:16:27 am
The fix is actually mine, it's just that I went to bed without remembering to commit it after passing it to Chief for testing. :)

It should fix the issue unless there are Linux compilers that don't support variadic macros. The fix only affects release builds as debug uses a different bit of code. For anything that isn't by MS it will use the proper variadic macro. For MS compilers it will use the truncated version. This will give a warning that the wrong number of arguments have been supplied if there are more than two, however you'll never see that warning anyway as it's a level 4 warning and therefore never shown when compiling release builds anyway.

If you have an idea for a better fix, I'm all ears though cause I'm not happy with this one. But AFAIK the macro will simply ignore any other arguments that are included beyond the first two.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]
 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: what macro?
Reply #14 on: May 30, 2009, 02:38:37 pm
I don't know of a supported way to compile it with MinGW anyway right now.  The Code::Blocks project is currently *nix-centric, as it sets the FS2_UNIX define or whatever it is.  It would be nice if that project could be platform agnostic but I don't know enough about that currently to make it work right.

Ok, after compiling in VC6, it seems to be fine with the macros, but not with some other code:

FRED compile error
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays
 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: what macro?
Reply #15 on: May 30, 2009, 03:31:15 pm
Looks like the VC6 version of CString didn't define a Trim function rather annoyingly. I'm not entirely sure what it does define in that case so I'm not certain how to fix this one.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]
 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: what macro?
Reply #16 on: May 30, 2009, 04:52:01 pm
Ok, Karajorma got that Trim thing sorted out and now compiling VC6 works, after that gets committed.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays
 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: what macro?
Reply #17 on: May 30, 2009, 05:05:02 pm
Yeah, committed it.

Let's hope that's the issues on all 3 platforms sorted once and for all. :D
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]
  

Offline asyikarea51

  • 210
  • -__-||
Re: what macro?
Reply #18 on: June 02, 2009, 05:43:56 am
 :bump:

Keeping a long story VERY short (+ I forgot the long story already :lol:), just wanted to say compiling on VC6 finally works again. Thanks! Here's hoping it doesn't suddenly fail on me again after posting this... XD

Half the reason why builds either crashed out (or successfully compiled but acted VERY STRANGELY in-game) for me all this time* in addition to all those weird errors above was due to MAX_WEAPONS :nervous:

*for a few months now I reckon.
Print
Pages: [1]   Go Up
« Previous Thread Next Thread »