[SirKnightly]

Here is the nightly for OS X on 31 Aug 2011 - Revision 7607

Group: Inferno
fso-OSX-Inferno-20110831_r7607.tgz
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r7585 | The_E | 2011-08-30 12:23:01 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/anim/animplay.cpp

PVS Studio fix: V541 It is dangerous to print the string 'ani_name' into itself.

------------------------------------------------------------------------
r7586 | The_E | 2011-08-30 12:24:50 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/stats/medals.cpp

PVS Studio fix: V541 It is dangerous to print the string 'base' into itself.

------------------------------------------------------------------------
r7587 | The_E | 2011-08-30 12:26:57 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/mission/missionbriefcommon.cpp
   M /trunk/fs2_open/code/parse/sexp.cpp

PVS Studio fix: V547 Expression 'character <= 127' is always true. The value range of signed char type: [-128, 127].

------------------------------------------------------------------------
r7588 | The_E | 2011-08-30 12:28:39 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/AltShipClassDlg.cpp

PVS Studio fix: V567 Undefined behavior. The 'index' variable is modified while being used twice between sequence points.

------------------------------------------------------------------------
r7589 | The_E | 2011-08-30 12:29:56 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/dumpstats.cpp

PVS Studio fix: V576 Incorrect format. A different number of actual arguments is expected while calling 'Format' function. Expected: 2. Present: 3.

------------------------------------------------------------------------
r7590 | Swifty | 2011-08-30 12:39:48 -0500 (Tue, 30 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelinterp.cpp

Engine glows no longer render when on the wrong side of a warp-in/out.
------------------------------------------------------------------------
r7591 | The_E | 2011-08-30 12:40:00 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/sound/dscap.cpp

PVS Studio fix: V581 The conditional expressions of the 'if' operators situated alongside each other are identical.

------------------------------------------------------------------------
r7592 | The_E | 2011-08-30 12:46:03 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/cutscene/cutscenes.cpp
   M /trunk/fs2_open/code/freespace2/freespace.cpp
   M /trunk/fs2_open/code/globalincs/pstypes.h
   M /trunk/fs2_open/code/menuui/mainhallmenu.cpp
   M /trunk/fs2_open/code/menuui/playermenu.cpp
   M /trunk/fs2_open/code/network/multiui.cpp
   M /trunk/fs2_open/code/playerman/player.h

Removing the RELEASE_REAL define from ye olde :v: days. We really don't need it anymore.

------------------------------------------------------------------------
r7593 | The_E | 2011-08-30 12:46:49 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/bmpman/bmpman.cpp
   M /trunk/fs2_open/code/cfile/cfilesystem.cpp
   M /trunk/fs2_open/code/graphics/font.cpp
   M /trunk/fs2_open/code/math/vecmat.cpp
   M /trunk/fs2_open/code/menuui/techmenu.cpp
   M /trunk/fs2_open/code/mission/missioncampaign.cpp
   M /trunk/fs2_open/code/mission/missionmessage.cpp
   M /trunk/fs2_open/code/network/multi_options.cpp
   M /trunk/fs2_open/code/network/multimsgs.cpp
   M /trunk/fs2_open/code/network/psnet2.cpp
   M /trunk/fs2_open/code/network/stand_gui.cpp
   M /trunk/fs2_open/code/parse/lua.cpp
   M /trunk/fs2_open/code/parse/scripting.cpp
   M /trunk/fs2_open/code/pcxutils/pcxutils.cpp
   M /trunk/fs2_open/code/playerman/managepilot.cpp
   M /trunk/fs2_open/code/sound/acm.cpp
   M /trunk/fs2_open/code/sound/audiostr.cpp

PVS Studio related: Mark false alarms as such.

------------------------------------------------------------------------
r7595 | Zacam | 2011-08-30 17:59:57 -0500 (Tue, 30 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelinterp.cpp

Fix for 7590: Shipp can be NULL, which would lead to a crash. This resolves that crash from happening.
------------------------------------------------------------------------
r7597 | Zacam | 2011-08-31 04:37:20 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

MSVC Analysis C6246: Local declaration of <variable> hides declaration of same name in outer scope. (wip, swp, objp, j)
------------------------------------------------------------------------
r7598 | Zacam | 2011-08-31 04:59:55 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/hud/hudlock.cpp

MSVC Analysis C6244: Local declaration of <variable> hides previous declaration at <line> of <file>. (lock_world_pos; 31; hudlock.cpp)
------------------------------------------------------------------------
r7599 | Zacam | 2011-08-31 05:58:33 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/menuui/barracks.cpp
   M /trunk/fs2_open/code/mission/missionhotkey.cpp

Clean up the commented out code from niffiwan's PVS-Studio patches. (from niffiwan)
------------------------------------------------------------------------
r7600 | Echelon9 | 2011-08-31 07:58:58 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/render/3dmath.cpp

PVS-Studio false positive: V537 Consider reviewing the correctness of 'y' item's usage (3dmath.cpp)
------------------------------------------------------------------------
r7601 | Echelon9 | 2011-08-31 08:00:57 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/sound/dscap.cpp

PVS-Studio false positive: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. Check lines: 185, 189 (dscap.cpp)
------------------------------------------------------------------------
r7602 | Echelon9 | 2011-08-31 08:02:44 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/hud/hudtarget.cpp

PVS-Studio false positive: V581 The conditional expressions of the 'if' operators situated alongside each other are identical.(hudtarget.cpp)
------------------------------------------------------------------------
r7603 | Echelon9 | 2011-08-31 08:12:46 -0500 (Wed, 31 Aug 2011) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/network/psnet2.cpp

PVS-Studio fix: V523 The 'then' statement is equivalent to the 'else' statement (psnet2.cpp).

This one was particular bad as it code have lead to remotely induced crashes over the network with oversize packets.
------------------------------------------------------------------------
r7604 | Echelon9 | 2011-08-31 08:25:14 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/autopilot/autopilot.cpp

PVS-Studio fix: V522 Dereferencing of the null pointer 'snd' might take place. Check the logical condition (autopilot.cpp)
------------------------------------------------------------------------
r7605 | Echelon9 | 2011-08-31 08:48:23 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/psnet2.cpp

Undo my rather silly patch, apply niffiwan's patch as a temporary measure (at least).
------------------------------------------------------------------------
r7606 | Echelon9 | 2011-08-31 08:53:14 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missionbriefcommon.cpp

cppcheck fix: Memory leak in icon table parsing.
------------------------------------------------------------------------
r7607 | karajorma | 2011-08-31 09:06:19 -0500 (Wed, 31 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multi_sexp.cpp

Fix a mismatch.
------------------------------------------------------------------------