Author Topic: JPG CBanims bug  (Read 9544 times)

0 Members and 1 Guest are viewing this topic.

Cursory scan looks like Gentoo and Arch have it in their repositories, yum has it as well.

It's lacking from either Ubuntu or Debian's repos, but there's a provided .deb file from the devs that will work on Debian-based systems.

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Wait, so people will need to download DLLs or something in addition to the FSO binary?  I thought we were going to build the library into the program so that we wouldn't need any external dependencies?

 
Wait, so people will need to download DLLs or something in addition to the FSO binary?  I thought we were going to build the library into the program so that we wouldn't need any external dependencies?

This is for the linux side, I think it's all packaged into the binary for windows. Right now for most of the external libraries, linux FSO compiles link against a system's installed libraries. I set things up to further that trend. I don't know for sure, but I'm pretty sure Zacam said, the external libraries for windows are all wrapped up into the FSO binary.

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Yeah, Goober, whatever's been discussed so far, nothing would really change at all for any platform but Linux, aside from possibly having a different library including in SVN, but even changing Windows to libjpeg-turbo doesn't sound necessary for this to work.  It would throw the warning that -turbo isn't being used though, but we could fix that simply by changing the library in SVN, or only throwing the warning on Linux.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
As an update, it looks like we would want to switch all platforms to -turbo after all.  Windows was confirmed yesterday to be exhibiting some form of bug with jpegs, and it's probably the same cause.  So, the legwork has already been done for Linux in DarkBasilisk's post, now we just need to do the MSVC and Xcode projects.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
So... then I repeat my previous question. :nervous:

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature

Windows would compile -turbo just like it currently compiles libjpeg. No external DLL required for FSO at all.

Building on Linux would have the dependency of needing to have -turbo installed, or some method to defaulting to the SVN provided iteration if a system library is not found.
But most linux users are more savvy than windows users and can probably figure that out pretty easily, or they wouldn't be using linux.

No clue on Mac, but I'm sure Chief, Echelon9 and jg18 can figure it out and I can haul my mac out as well. Worst case scenario, it builds into the app what is in SVN.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline MatthTheGeek

  • Captain Obvious
  • 212
  • Frenchie McFrenchface

Building on Linux would have the dependency of needing to have -turbo installed, or some method to defaulting to the SVN provided iteration if a system library is not found.
But most linux users are more savvy than windows users and can probably figure that out pretty easily, or they wouldn't be using linux.

As someone who has compiled on linux in the past, I can tell than the number of dependencies required is already large. One more or one less is absolutely no trouble.
People are stupid, therefore anything popular is at best suspicious.

Mod management tools     -     Wiki stuff!     -     Help us help you

666maslo666: Releasing a finished product is not a good thing! It is a modern fad.

SpardaSon21: it seems like you exist in a permanent state of half-joking misanthropy

Axem: when you put it like that, i sound like an insane person

bigchunk1: it's not retarded it's american!
bigchunk1: ...

batwota: steele's maneuvering for the coup de gras
MatthTheGeek: you mispelled grâce
Awaesaar: grace
batwota: oh right :P
Darius: ah!
Darius: yes, i like that
MatthTheGeek: the way you just spelled it it means fat
Awaesaar: +accent I forgot how to keyboard
MatthTheGeek: or grease
Darius: the killing fat!
Axem: jabba does the coup de gras
MatthTheGeek: XD
Axem: bring me solo and a cookie

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Goob, the end result wouldn't be any different for the user.  We'd just be switching out libjpeg for libjpeg-turbo in SVN, and compiling it in the same way we always have.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline pecenipicek

  • Roast Chicken
  • 211
  • Powered by copious amounts of coffee and nicotine
    • Skype
    • Steam
    • Twitter
    • PeceniPicek's own deviantart page

Building on Linux would have the dependency of needing to have -turbo installed, or some method to defaulting to the SVN provided iteration if a system library is not found.
But most linux users are more savvy than windows users and can probably figure that out pretty easily, or they wouldn't be using linux.

As someone who has compiled on linux in the past, I can tell than the number of dependencies required is already large. One more or one less is absolutely no trouble.
Agreed here.
Skype: vrganjko
Ho, ho, ho, to the bottle I go
to heal my heart and drown my woe!
Rain may fall and wind may blow,
and many miles be still to go,
but under a tall tree I will lie!

The Apocalypse Project needs YOU! - recruiting info thread.

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Goob, the end result wouldn't be any different for the user.  We'd just be switching out libjpeg for libjpeg-turbo in SVN, and compiling it in the same way we always have.
That's what I thought, but I wanted to make sure.  Cool.

 

Offline niffiwan

  • 211
  • Eluder Class
Just an update on the status of this...

There's been some problems getting the libjpeg-turbo library to work on all platforms so in the interim I've committed a patch to trunk (r7891) which does a colour byte swap in the FSO jpeg routines.  I've tested this successfully with the WoD jpeg loading screens, when the nightlies are updated could some more people test this out, e.g. Nighteyes with the CBanims?

I'm going to continue to see if I can get libjpeg-turbo sorted out, but it may take some time and we don't want to delay a fix for this issue too much longer :)
Creating a fs2_open.log | Red Alert Bug = Hex Edit | MediaVPs 2014: Bigger HUD gauges | 32bit libs for 64bit Ubuntu
----
Debian Packages (testing/unstable): Freespace2 | wxLauncher
----
m|m: I think I'm suffering from Stockholm syndrome. Bmpman is starting to make sense and it's actually written reasonably well...

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
We sure don't, this is definitely good enough to get 3.6.14 out the door, as people don't really use jpeg much these days anyway, but we don't want a regression.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
That loop could be made more efficient.  Instead of counting by ones and dividing by three each time, it should count by threes.  Use k += 3 instead of k++.

  

Offline niffiwan

  • 211
  • Eluder Class
The efficiency suggestion has been committed in trunk r7898 - thanks Goober5000 & Iss Mneur (apologies to Zacam who now has to backport to antipodes & 3.6.14 again! :))
Creating a fs2_open.log | Red Alert Bug = Hex Edit | MediaVPs 2014: Bigger HUD gauges | 32bit libs for 64bit Ubuntu
----
Debian Packages (testing/unstable): Freespace2 | wxLauncher
----
m|m: I think I'm suffering from Stockholm syndrome. Bmpman is starting to make sense and it's actually written reasonably well...