Author Topic: Fix to serious -pcx32 bug  (Read 943 times)

0 Members and 1 Guest are viewing this topic.

Offline RandomTiger

  • Senior Member
  • 211
Fix to serious -pcx32 bug
I've just discovered quite a bad bug I put into fs2_open.
When using -pcx32 bitmaps loaded from pcx would get loaded into memory twice. And only unloaded once.

That could actually account for some of the problems people have been experiencing. Sorry about that.

Heres a fixed exe.

http://mysite.freeserve.com/thomaswhittaker/c_code/freespace/fs2_open_r.rar

 
Fix to serious -pcx32 bug
As in loaded into main memory (i.e. not graphics memory)?  This could explain the 1gb memory requirement of FS2_open I've been experiencing recently.  As soon as my main computer works again...

 

Offline redsniper

  • 211
  • Aim for the Top!
Fix to serious -pcx32 bug
Aha! this explains the size of my page file
"Think about nice things not unhappy things.
The future makes happy, if you make it yourself.
No war; think about happy things."   -WouterSmitssm

HARD LIGHT PRODUCTIONS:
"...this conversation is pointlessly confrontational."

 

Offline Lightspeed

  • Light Years Ahead
  • 212
Fix to serious -pcx32 bug
this is a modified 20_01_04 build?

You should stick to the naming convention of builds, else this is getting very confusing. :doubt:
Modern man is the missing link between ape and human being.

  

Offline RandomTiger

  • Senior Member
  • 211
Fix to serious -pcx32 bug
Turns out its not as bad as I thought, the memory should have been freed OK before mallocing the new one later on in the code.

Was still a bad bug though.