Author Topic: Patch for Matnis#1700  (Read 3078 times)

0 Members and 1 Guest are viewing this topic.

Patch for Matnis#1700
First post and directly violating the rules :nervous:
But I cannot register at the Mantis Website (it doesn't send me any emails), so I post it here:

I created a patch for this proposal.
This patch adds a "-weapon_choice_3d" command line flag.

-DerKuchen

[attachment deleted by admin]

 

Offline Galemp

  • Actual father of Samus
  • 212
  • Ask me about GORT!
    • Steam
    • User page on the FreeSpace Wiki
Re: Patch for Matnis#1700
yay! is my bug! :D
"Anyone can do any amount of work, provided it isn't the work he's supposed to be doing at that moment." -- Robert Benchley

Members I've personally met: RedStreblo, Goober5000, Sandwich, Splinter, Su-tehp, Hippo, CP5670, Terran Emperor, Karajorma, Dekker, McCall, Admiral Wolf, mxlm, RedSniper, Stealth, Black Wolf...

 

Offline jr2

  • The Mail Man
  • 212
  • It's prounounced jayartoo 0x6A7232
    • Steam
Re: Patch for Matnis#1700
....Someone beamz0r him already?  xD

 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: Patch for Matnis#1700
First post and directly violating the rules :nervous:
 

It violates the rules to report bugs on here when you could report them on Mantis. Fixing bugs is another matter entirely. :p As for the patch, well blowfish said he wanted to take a look at it but I guess if you snooze you lose. :p I'll take a look at the code now.

EDIT : Took a quick glance and it looked fine to me. It's in this build so people can test.
« Last Edit: June 25, 2008, 12:25:40 pm by karajorma »
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]

 

Offline blowfish

  • 211
  • Join the cult of KILL MY ROUTER!!!!!!!!!!1
Re: Patch for Matnis#1700
Yeah ... looks good.  I actually wanted to add an option to use the tech model if it is found but otherwise use the ANI, but that can wait.  Good job with this, DerKuchen.  And

:welcomeblue:

 

Offline Galemp

  • Actual father of Samus
  • 212
  • Ask me about GORT!
    • Steam
    • User page on the FreeSpace Wiki
Re: Patch for Matnis#1700
Personally, I'd rather it use the ANI first, then the tech model. At least until that bug with the rotation-zoom-centering is fixed.

Erm... wait. Does this deactivate weapon model use when ONLY the ship_select_3D is turned on? That's the big problem, I wanted realtime ships and pre-rendered weapons.
« Last Edit: June 25, 2008, 12:39:22 pm by Galemp »
"Anyone can do any amount of work, provided it isn't the work he's supposed to be doing at that moment." -- Robert Benchley

Members I've personally met: RedStreblo, Goober5000, Sandwich, Splinter, Su-tehp, Hippo, CP5670, Terran Emperor, Karajorma, Dekker, McCall, Admiral Wolf, mxlm, RedSniper, Stealth, Black Wolf...

 

Offline blowfish

  • 211
  • Join the cult of KILL MY ROUTER!!!!!!!!!!1
Re: Patch for Matnis#1700
Personally, I'd rather it use the ANI first, then the tech model. At least until that bug with the rotation-zoom-centering is fixed.

Erm... wait. Does this deactivate weapon model use when ONLY the ship_select_3D is turned on? That's the big problem, I wanted realtime ships and pre-rendered weapons.

Actually, that could be fixed quite easily by just disabling the weird rotation zoom center if the tech model is found.  There is probably a better, but more complicated solution, however ... Well, I'll look into this.

EDIT: It seems that for missiles it sort of hack-calculates the center of the model.  Would it be acceptable to just autocenter the model, or would this cause problems?  Actually, it might be better to set a flag from when rendering the model in the loadout screen.  I need feedback on this :confused:
« Last Edit: June 25, 2008, 01:03:12 pm by blowfish »

 

Offline jr2

  • The Mail Man
  • 212
  • It's prounounced jayartoo 0x6A7232
    • Steam
Re: Patch for Matnis#1700
Why don't you guys use http://scp.indiegames.us.pastebin.com and work out all of these things cooperatively?  ;)  Swap ideas back and forth; it might make it easier, IDK.

 

Offline phreak

  • Gun Phreak
  • 211
  • -1
Re: Patch for Matnis#1700
EDIT: It seems that for missiles it sort of hack-calculates the center of the model.  Would it be acceptable to just autocenter the model, or would this cause problems?  Actually, it might be better to set a flag from when rendering the model in the loadout screen.  I need feedback on this :confused:

It incorrectly hack-calculated the center of the model, which is why the new ones spun on their noses.  Fixed.
Offically approved by Ebola Virus Man :wtf:
phreakscp - gtalk
phreak317#7583 - discord

 

Offline blowfish

  • 211
  • Join the cult of KILL MY ROUTER!!!!!!!!!!1
Re: Patch for Matnis#1700
Why was it done that way in the first place :wtf:

 

Offline taylor

  • Super SCP/Linux Guru
  • Moderator
  • 212
    • http://www.icculus.org/~taylor
Re: Patch for Matnis#1700
Why was it done that way in the first place :wtf:
I think that I copied it from the autocenter hack in the weapon choice screen and then forgot to go back and fix it to be right.  :sigh: