Author Topic: Post-processing (Read 71643 times)

Hery · **Reply #160 on:** October 12, 2009, 05:52:55 pm

The problem is solved. Tomorrow I will experiment with DaBrain suggestion to make extreme colors glow and then I will post updated builds.

Topgun · **Reply #161 on:** October 12, 2009, 07:23:37 pm

we should map intensity to a new map/channel, rather than making glow be based on color.

Tolwyn · **Reply #162 on:** October 13, 2009, 03:33:56 am

Here's my log

At least the EXE is no longer crashing upon start.

I have a Radeon 4650 card, by the way.

[attachment deleted by admin]

DaBrain · **Reply #163 on:** October 13, 2009, 03:51:06 am

Quote from: Topgun on October 12, 2009, 07:23:37 pm

we should map intensity to a new map/channel, rather than making glow be based on color.

That would involve altering the current ship shaders... (Even then I don't know if it's actually possible...)

I doubt that is a good idea until Hery is done with the resource and material systems.

Nighteyes · **Reply #164 on:** October 13, 2009, 06:00:17 am

can't we just make the glow maps glow? and on top of that the regular specular bloom?

DaBrain · **Reply #165 on:** October 13, 2009, 06:59:27 am

That's the same thing Topgun asked for.

Hery · **Reply #166 on:** October 13, 2009, 07:33:54 am

Quote from: Topgun on October 12, 2009, 07:23:37 pm

we should map intensity to a new map/channel, rather than making glow be based on color.

Bloom is based on luminance, not color.
Personally, I don't see many reasons to use G-buffer to store bloom intensity.

Quote

can't we just make the glow maps glow? and on top of that the regular specular bloom?

If you make them bright enough they will glow.

@Tolwyn: what about -post_process flag?

Commander Zane · **Reply #167 on:** October 13, 2009, 07:36:25 am

Quote from: Hery on October 13, 2009, 07:33:54 am

If you make them bright enough they will glow.

Glow as in X3: Terran Conflict glowmap glows? Show me.

Hery · **Reply #168 on:** October 13, 2009, 07:48:06 am

They have to be bright enough not to be cut off by high-pass filter.
Ok, I agree that it is a good idea to make bloom at some places more intense than at the another, but that won't be achieved until alpha channel is used by opaque objects. However, that will be only an addition to the current effect that probably will make things easier.

Tolwyn · **Reply #169 on:** October 13, 2009, 07:54:52 am

Quote from: Hery on October 13, 2009, 07:33:54 am

@Tolwyn: what about -post_process flag?

Crap. Knew I forgot something...

[attachment deleted by admin]

Hery · **Reply #170 on:** October 13, 2009, 08:00:22 am

brightpass-f.sdr

Code: [Select]

uniform sampler2D tex;

const float Luminance = 0.08;
const float fMiddleGray = 0.18;
const float fWhiteCutoff = 0.8;

// High-pass filter
void main() {
	vec4 ColorOut = texture2D(tex, gl_TexCoord[0].xy);

	ColorOut *= fMiddleGray / ( Luminance + 0.001 );
	ColorOut *= ( 1.0 + ( ColorOut / ( fWhiteCutoff * fWhiteCutoff ) ) );
	ColorOut -= 6.0;

	ColorOut = max( ColorOut, 0.0 );

//	ColorOut /= ( 10.0 + ColorOut );

	gl_FragColor = ColorOut;
}

Nemesis6 · **Reply #171 on:** October 13, 2009, 11:00:06 am

I have encountered two bugs with last downloadable version posted by Hery: 50% of the time, upon loading up a mission from the standard campaign, I'll get an error about some thing that didn't load or something, didn't get to see it in full, sorry. Second, when I check the spinning weapon animations on the loudout screen, one will be replaced with a kind of template image. Lastly, on the Knossos portal, the surfaces would have a sort of purple shine, like the glowmap or something is missing. Got some screenshots, looking for the location they're saved now.

The E · **Reply #172 on:** October 13, 2009, 11:06:37 am

In your FS2 folder, there should be a folder called screenshots. The images will be there in tga format; you'll need to convert them to jpg or png before uploading.

If you're on Vista or 7, and FS2 is in C:\program files\, you may need to click on the "Compatibility files" button in the Explorer window that shows up when you're looking at the FS2 folder.

Nemesis6 · **Reply #173 on:** October 13, 2009, 11:37:44 am

http://img394.imageshack.us/i/screen0001.jpg/
http://img384.imageshack.us/i/screen0002.jpg/

I'll see if I can get some of the errors... damn, lazyness is a burden.

Hery · **Reply #174 on:** October 13, 2009, 11:45:07 am

There was a bug that lookd similar to this but I'm nearly 100% sure it is already fixed. Have you checked if this happens on other builds?

Error messages in FSO are ususally copied to the clipboard.
I would like you to run this mission on debug build and send me the log (which is in Data/fs2_open.log in the main fs directory).

Update: I've played a mission with Knossos and env mapping looks similar to the "problems" on your screenshots. Are you sure it's not a feature but a bug?

Nighteyes · **Reply #175 on:** October 13, 2009, 12:40:19 pm

Any idea why its working in one mod and in another not? in Earth Defence its working, but in Diaspora all i get is a hud and a black screen, while the game plays in the background...

Tolwyn · **Reply #176 on:** October 13, 2009, 12:55:25 pm

Quote from: Hery on October 13, 2009, 08:00:22 am

brightpass-f.sdr
Code: [Select]
uniform sampler2D tex; const float Luminance = 0.08; const float fMiddleGray = 0.18; const float fWhiteCutoff = 0.8; // High-pass filter void main() { vec4 ColorOut = texture2D(tex, gl_TexCoord[0].xy); ColorOut *= fMiddleGray / ( Luminance + 0.001 ); ColorOut *= ( 1.0 + ( ColorOut / ( fWhiteCutoff * fWhiteCutoff ) ) ); ColorOut -= 6.0; ColorOut = max( ColorOut, 0.0 ); // ColorOut /= ( 10.0 + ColorOut ); gl_FragColor = ColorOut; }

Still no difference...

Code: [Select]

Frame  0 too long!!: frametime = 57.573 (57.573)
Got event GS_EVENT_ENTER_GAME (2) in state GS_STATE_BRIEFING (10)
Entering game at time =  78.280
render_target: creating new 256x256 FBO
texture_pool: creating new 256x256 texture
texture_pool: creating new 256x256 texture
  Compiling special shader ->  post-v.sdr / brightpass-f.sdr ... 
  Compiling special shader ->  post-v.sdr / blur-f.sdr ... 
Fragment shader failed to compile:
Fragment shader failed to compile with the following errors:
ERROR: 0:2: '' :  #version must occur before any other statement in the program
ERROR:  compilation errors.  No code generated.

ERROR! Unable to create fragment shader!
Post-processing disabled.

Hery · **Reply #177 on:** October 13, 2009, 01:08:01 pm

@Nighteyes: No idea until I see the debug log. That's an old bug that I completely forgot about. Additionally, I haven't heard of any other mod that has such problems with post-processing.

@Tolwyn: that's a big difference

Now, the whole brightpass-f.sdr code is acceptable for Ati cards. The problems causes bloom-f.sdr, but to fix that I'll have to do some modifications in FSO code, so the build will be available later.

Update:
Cockpit clipping problem: solved.
A few of the large number of problems with shaders on Ati cards: solved.
Additional modifications: more intense bloom (if you don't like it, then just take advantage of -bloom_intensity flag

)

Download

Please, attach debug log to your bug report. That will make solving problems much easier and faster.

Tolwyn · **Reply #178 on:** October 13, 2009, 03:15:17 pm

Allright, updated shaders and the EXE and run the debug build again. Here's the output.

Code: [Select]

Frame  0 too long!!: frametime = 37.147 (37.147)
Got event GS_EVENT_ENTER_GAME (2) in state GS_STATE_BRIEFING (10)
Entering game at time =  60.702
render_target: creating new 256x256 FBO
render_buffer: creating new 256x256 render buffer
texture_pool: creating new 256x256 texture
texture_pool: creating new 256x256 texture
  Compiling special shader ->  post-v.sdr / brightpass-f.sdr ... 
  Compiling special shader ->  post-v.sdr / blur-f.sdr ... 
  Compiling post shader (0x1f) ->  post-v.sdr / post-f.sdr ...

Hery · **Reply #179 on:** October 13, 2009, 03:34:03 pm

There is no error message in that part of the log, so it means that all shaders compiled without problems. However, in most cases the first post shader is 0 (no 0x1f). Is this a post-processing demo mission or have you changed anything in post_processing.tbl?

News:

Author Topic: Post-processing (Read 71643 times)

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing

Re: Post-processing