[mjn.mixael]

*SNIP*

Having said all this, I don't know if this is a great solution because it seems that the campaign doesn't get ended properly anyway, i.e. after either the good or bad ending you can click on the "continue campaign" button and it lets you replay the end mission instead of saying "campaign is complete" (but I if my memory is correct it was this way in retail anyway).

This is a problem that exists regardless of your patch. This should probably be Mantised.

The whole end cutscene thing seems like a bit of a hack to me, wouldn't it be cleaner to have a "post mission cutscene" directive that you could add to the campaign file, similar to "+Briefing Cutscene:"?   Of course we're stuck with it now due to the "don't break retail" directive

This is already possible... If it were up to me.. I would add it to the mission file in the MediaVPs.

[niffiwan]

OK - mantised here http://scp.indiegames.us/mantis/view.php?id=2482

[Goober5000]

Part of this sounds very similar to the No Supernova situation from retail FS2.

[niffiwan]

Heh - great thread

In my testing I've been making sure that I destroy that Cain though (and the Rakshasa since its destruction triggers the Cains arrival), since the its destruction is the supernova trigger.  Annoying, otherwise I could just fly off into deepspace on speed x64 to test the "bad" ending...

Actually, I'd just thought of something - does using the cheat codes prevent you from advancing to the next mission or anything like that?  A couple of ~+k's would make the testing go faster 

[Goober5000]

Cheating does not prevent advancing.

In fact, you should be able to use the 'skipmemymissionyo' cheat to advance to the last mission in the campaign, but since this is a non-standard method of advancement, it may not be an appropriate strategy.

[jon118]

I've been having a dig around in the code and I've got the good ending cutscenes to play as expected by re-adding some commented out code:

Fantastic work niffiwan!

I had been looking for this, but the commented-out code had been removed completely in builds after 3.6.12 and I hadn't looked in the 3.6.12 branch for "GS_EVENT_END_CAMPAIGN". 

I built the latest SVN with the removed code added back in, and the ending movie plays just like it used to.


Bug fixed.


However, I do have to agree that this way of getting the end movie to play and set the campaign to "ended" is pretty hacky.

But for now, it gets the job done.


I don't know why this was so hard for others to reproduce, since it would happen to everyone who plays the final mission in builds >= 3.6.12. Period.  Without the removed code, the logic simply does not exist to cause the "successful" end movie to play.


Good work.

[MarsNeedsWomen]

So what is the fix necessarily? How do I install it?

[niffiwan]

You need to be able to build your own FSO binary from SVN. Get the latest SVN and apply the patch from this post

Alternatively, wait until a real fix appears in a 3.6.14 RC build.

[jg18]

Looking at this thread and the relevant Mantis issues is starting to make my head spin when it comes to figuring out what the expected behavior is and what currently does(n't) work.

From what I can tell, there are two separate but related issues:
(1) whether the ending cutscenes play
(2) whether the campaign ends

If I understand right, the issue under discussion in this thread is the ending cutscenes not playing when you jump out successfully, although the campaign still ends in this case. And it sounds like this particular issue is fixed in niffiwan's patch, although it hasn't (yet?) been committed.

But niffiwan's Mantis issue is about the campaign not ending at all, I think. But now I'm unclear as to whether it should end if you die in the supernova.

I dunno, maybe I should do a better job of RTFM (read the f'ing Mantis).

[Goober5000]

It's a complicated issue.  I'm trying to set aside time to sit and take a careful look at it.

[jon118]

For those who may have missed the info on Mantis, I'll copy and paste my description of what should happen below.

Basically, as long as issue 0002478 (the issue THIS thread is about) remains unfixed, the game is NOT behaving like retail.  The ending movies ARE supposed to play, and the campaign is NOT supposed to be marked as ended--if retail behavior is intact.

Honestly, the whole "campaign not ended" issue is kind of a distraction right now, as it isn't really an issue, and is mostly unrelated to the end movie not playing.  However, the ending movie not playing IS a pretty bad issue, as it also ends the campaign and forces the player to start from the very beginning while also robbing them of the ending "climax." 

At the moment, when you fight your way to the ending battle through 30+ missions, the game basically says "Oh did you think you WON?!? PSYCH!!! HAHAHA!!! No movie and back to the beginning for you!!! Muhahahaha! Sucka!!!"

As Yarn mentioned above, the first possible ending (the good one), only happens if issue 0002478 is fixed and returned to its retail behavior (and the player jumps out *DURING* the supernova *AND* also jumps while *INSIDE* the node, but *BEFORE* the supernova hits the player's ship)--just in case that needed to be clarified.

If issue 0002478 is *not* fixed, then the campaign end behavior is *not* like retail, and the good end cutscene is *not* played--no matter what the player does in the campaign. (And the campaign is closed, forcing the player to start over from the beginning because the cutscene did not play.)

From what Yarn mentioned on possible ending 3 (player jumps out at the node before the supernova starts), it sounds like *that* would be the main thing to fix in regard to this 0002482 issue (even if that actually is the original retail behavior), since it closes the campaign and forces the player to start over if they accidentally hit "Alt+J" at the wrong place and time.

[Goober5000]

Yes.  This is a prerequisite to 3.6.14 final.

In fact, I intend to get it fixed this weekend.

[jon118]

Any chance a fix will make it into RC6, Goob?

[Goober5000]

There is always a chance.  But RL seems to be kicking everyone's butts at the moment, including mine.

[jon118]

Yeah, I hear ya there...

And thanks for all you guys do!

[jon118]

Thanks for putting the code back in Goob. This should finally be fixed now (in RC7 or higher).

[Goober5000]

[AV8R]

Hate to dredge up this old fossil but apparently this is still an issue in 3.6.14 RC6.

Just finished the campaign and got the no briefing error and no cutscene after reaching the node and jumping out on time.....

Bummer. 

[AV8R]

Crap! Had I'd known RC7 was out I would have tried that to see if it worked.

Now I have to play the whole campaign over again. 

[AV8R]

Ok, that didn't work out so well. Check out the issues I posted under the RC7 thread:

http://www.hard-light.net/forums/index.php?topic=81558.0