Author Topic: Nightly (Windows): 04 Jul 2016 - Revision 774140d  (Read 898 times)

0 Members and 1 Guest are viewing this topic.

Offline SirKnightly

  • George or Keira?
  • 211
Nightly (Windows): 04 Jul 2016 - Revision 774140d
Here is the nightly for Windows on 04 Jul 2016 - Revision 774140d

Open non-feature issues in Mantis: 123

Group: NO-SSE
fso_NO-SSE_20160704_774140d.7z
MD5Sum

Group: Standard
fso_Standard_20160704_774140d.7z
MD5Sum

Group: AVX
fso_AVX_20160704_774140d.7z
MD5Sum

Group: SSE
fso_SSE_20160704_774140d.7z
MD5Sum

Code: [Select]
------------------------------------------------------------------------
commit bf6cbb9
Author: MageKing17 <Sun Jul 3 02:17:07 2016 -0700>
Commit: MageKing17 <Sun Jul 3 02:17:07 2016 -0700>

    Fix color table parsing.
 code/globalincs/alphacolors.cpp | 1 +
 1 file changed, 1 insertion(+)



 

Offline Trivial Psychic

  • 212
  • Snoop Junkie
Re: Nightly (Windows): 04 Jul 2016 - Revision 774140d
Be advised, the launcher won't display the date line or the code identifier line in the name for this build.  It is simply listed as "FS2 Open 3.7.5 (CPU Variant)".
The Trivial Psychic Strikes Again!

 

Offline AdmiralRalwood

  • 211
  • The Cthulhu programmer himself!
    • Skype
    • Steam
    • Twitter
Re: Nightly (Windows): 04 Jul 2016 - Revision 774140d
Be advised, the launcher won't display the date line or the code identifier line in the name for this build.  It is simply listed as "FS2 Open 3.7.5 (CPU Variant)".
It's an annoying side-effect of the hash ending in "d" that should probably be fixed at some point.
Ph'nglui mglw'nafh Codethulhu GitHub wgah'nagl fhtagn.

schrödinbug (noun) - a bug that manifests itself in running software after a programmer notices that the code should never have worked in the first place.

When you gaze long into BMPMAN, BMPMAN also gazes into you.

"I am one of the best FREDders on Earth" -General Battuta

<Aesaar> literary criticism is vladimir putin

<MageKing17> "There's probably a reason the code is the way it is" is a very dangerous line of thought. :P
<MageKing17> Because the "reason" often turns out to be "nobody noticed it was wrong".
(the very next day)
<MageKing17> this ****ing code did it to me again
<MageKing17> "That doesn't really make sense to me, but I'll assume it was being done for a reason."
<MageKing17> **** ME
<MageKing17> THE REASON IS PEOPLE ARE STUPID
<MageKing17> ESPECIALLY ME

<MageKing17> God damn, I do not understand how this is breaking.
<MageKing17> Everything points to "this should work fine", and yet it's clearly not working.
<MjnMixael> 2 hours later... "God damn, how did this ever work at all?!"
(...)
<MageKing17> so
<MageKing17> more than two hours
<MageKing17> but once again we have reached the inevitable conclusion
<MageKing17> How did this code ever work in the first place!?

<@The_E> Welcome to OpenGL, where standards compliance is optional, and error reporting inconsistent

<MageKing17> It was all working perfectly until I actually tried it on an actual mission.

<IronWorks> I am useful for FSO stuff again. This is a red-letter day!
* z64555 erases "Thursday" and rewrites it in red ink

<MageKing17> TIL the entire homing code is held up by shoestrings and duct tape, basically.

 

Offline jg18

  • A very happy zod
  • 210
  • can do more than spellcheck
Re: Nightly (Windows): 04 Jul 2016 - Revision 774140d
I think this should fix both this issue and also a similar issue with tokens consisting of numbers followed by an 'r'.

Code: [Select]
diff --git a/code/datastructures/FSOExecutable.cpp b/code/datastructures/FSOExecutable.cpp
index 9b3feed..9a84b1d 100644
--- a/code/datastructures/FSOExecutable.cpp
+++ b/code/datastructures/FSOExecutable.cpp
@@ -278,6 +278,7 @@ FSOExecutable FSOExecutable::GetBinaryVersion(wxString binaryname) {
  wxLogWarning(
  _T("Revision version number out of range (%ld) in executable %s"),
  tempVersion, binaryname.c_str());
+ ver.string += wxString::Format(ver.string.IsEmpty() ? _T("%s") : _T(" %s"), token.c_str());
  }
  } else {
  wxLogWarning(
@@ -297,6 +298,7 @@ FSOExecutable FSOExecutable::GetBinaryVersion(wxString binaryname) {
  wxLogWarning(
  _T("Revision version number out of range (%ld) in executable %s"),
  tempVersion, binaryname.c_str());
+ ver.string += wxString::Format(ver.string.IsEmpty() ? _T("%s") : _T(" %s"), token.c_str());
  }
  } else {
  wxLogWarning(

I don't have a wxL fork set up at the moment but I'll try to get on that and generate a pull request this week.

 

Offline Iss Mneur

  • 210
  • TODO:
Re: Nightly (Windows): 04 Jul 2016 - Revision 774140d
The bug in wxLauncher handling of the git hashs now has a patch that will be in the next release of wxLauncher.
"I love deadlines. I like the whooshing sound they make as they fly by." -Douglas Adams
wxLauncher 0.9.4 public beta (now with no config file editing for FRED) | wxLauncher 2.0 Request for Comments