Author Topic: Should has-arrived-delay (ship present at mission start) = true?  (Read 196 times)

0 Members and 1 Guest are viewing this topic.

Offline General Battuta

  • Poe's Law In Action
  • 214
  • i wonder when my postcount will exceed my iq
Should has-arrived-delay (ship present at mission start) = true?
Cause it ain't.

We should check how this behaves in retail vs how it behaves now.

 

Offline TopAce

  • Stalwart contributor
  • 212
  • FREDder, FSWiki editor, and tester
Re: Should has-arrived-delay (ship present at mission start) = true?
I don't see this breaking any backwards compatibility so why not. But why would you use it as such?
My community contributions - Get my campaigns from here.

I already announced my retirement twice, yet here I am. If I bring up that topic again, don't believe a word.

 

Offline Novachen

  • 29
  • The one and only capella supernova
    • Twitter
Re: Should has-arrived-delay (ship present at mission start) = true?
Stumpled upon this one once, but i have to say, that the current behaviour make sense to me.
« Last Edit: November 29, 2020, 12:28:31 pm by Novachen »
Female FreeSpace 2 pilot since 1999.
Former Global moderator in the German FreeSpace Galaxy Forum.

Is one of my releases broken or not working? Please send a PM here or on Twitter, a public tweet @NovachenFS2 or write a reply in my own release threads here on HLP, because these are the only threads i am still participating in.

 

Offline DefCynodont119

  • 29
  • I should put something witty here- but not this. .
    • Steam
Re: Should has-arrived-delay (ship present at mission start) = true?
Correct me if I'm wrong, but isn't this what the "is-in-mission" SEXP is for?
My gift from Freespace to Cities Skylines:  http://steamcommunity.com/sharedfiles/filedetails/?id=639891299

 

Offline General Battuta

  • Poe's Law In Action
  • 214
  • i wonder when my postcount will exceed my iq
Re: Should has-arrived-delay (ship present at mission start) = true?
Correct me if I'm wrong, but isn't this what the "is-in-mission" SEXP is for?

Is-in-mission won't stay true once a ship is dead. So say you have the GTD Gadzooks in mission at time 0, and it dies at time 1. If you want to check whether it's ever been in the mission at time 100000, you can't use either is-in-mission or has-arrived-delay (since it's not in the mission AND it hasn't arrived). But you could use an or (is in mission) (is destroyed delay).

But I don't want to change this behavior, it is what it is. I just want to be sure WE haven't changed it since retail.

 

Offline AdmiralRalwood

  • 211
  • The Cthulhu programmer himself!
    • Skype
    • Steam
    • Twitter
Re: Should has-arrived-delay (ship present at mission start) = true?
I'd be very surprised if this has changed since retail, since the basic behavior is very straightforward (has-arrived-delay checks the mission log, and ships that start in the mission are never logged as "arrived"); that being said, just because I can't see anything in the :v: code that would make it behave differently doesn't necessarily mean it doesn't behave differently, so if somebody could test and confirm, it would be appreciated. Or I could do it, but I'm lazy.
Ph'nglui mglw'nafh Codethulhu GitHub wgah'nagl fhtagn.

schrödinbug (noun) - a bug that manifests itself in running software after a programmer notices that the code should never have worked in the first place.

When you gaze long into BMPMAN, BMPMAN also gazes into you.

"I am one of the best FREDders on Earth" -General Battuta

<Aesaar> literary criticism is vladimir putin

<MageKing17> "There's probably a reason the code is the way it is" is a very dangerous line of thought. :P
<MageKing17> Because the "reason" often turns out to be "nobody noticed it was wrong".
(the very next day)
<MageKing17> this ****ing code did it to me again
<MageKing17> "That doesn't really make sense to me, but I'll assume it was being done for a reason."
<MageKing17> **** ME
<MageKing17> THE REASON IS PEOPLE ARE STUPID
<MageKing17> ESPECIALLY ME

<MageKing17> God damn, I do not understand how this is breaking.
<MageKing17> Everything points to "this should work fine", and yet it's clearly not working.
<MjnMixael> 2 hours later... "God damn, how did this ever work at all?!"
(...)
<MageKing17> so
<MageKing17> more than two hours
<MageKing17> but once again we have reached the inevitable conclusion
<MageKing17> How did this code ever work in the first place!?

<@The_E> Welcome to OpenGL, where standards compliance is optional, and error reporting inconsistent

<MageKing17> It was all working perfectly until I actually tried it on an actual mission.

<IronWorks> I am useful for FSO stuff again. This is a red-letter day!
* z64555 erases "Thursday" and rewrites it in red ink

<MageKing17> TIL the entire homing code is held up by shoestrings and duct tape, basically.

 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: Should has-arrived-delay (ship present at mission start) = true?
This absolutely would break retail.

Has-arrived-delay always worked that way. It's only meant to be used for ships which aren't in the mission at t=0 (the mission designer is supposed to know which ships are there at t=0 even if this is dependent on a SEXP for the arrival cue). This behaviour used to be well known enough that I considered it an intermediate level question when I wrote my original FRED quiz.

We could always change the text for the SEXP if it isn't clear enough though.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]

 

Offline General Battuta

  • Poe's Law In Action
  • 214
  • i wonder when my postcount will exceed my iq
Re: Should has-arrived-delay (ship present at mission start) = true?
I absolutely agree, it shouldn't be changed.

Just as a point of curiosity, though — would it break retail? Or anything? How often are mission designers going to be checking if a ship present at mission start has arrived, and counting on getting a 'no'?

The only thing I can imagine breaking is us accidentally UN-breaking stuff which has been broken the whole time.

  

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: Should has-arrived-delay (ship present at mission start) = true?
I can definitely see having a ship's arrival cue being dependent on -is-previous-event-true so that the ship is either present at mission start or arrives later on in the mission. 

In that case, you would simply test if the ship has arrived for the purposes of sending messages etc.


In fact, I'm pretty sure I actually did that in a few missions.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]