Author Topic: Nightly: 20 January 2022 - Revision 33fa58400  (Read 364 times)

0 Members and 1 Guest are viewing this topic.

Offline SirKnightly

  • George or Keira?
  • 211
Nightly: 20 January 2022 - Revision 33fa58400
Here is the nightly for 20 January 2022 - Revision 33fa58400



Group: Win64-SSE2
nightly_20220120_33fa58400-builds-x64-SSE2.zip (Mirror)


Group: Linux
nightly_20220120_33fa58400-builds-Linux.tar.gz (Mirror)


Group: Win32-SSE2
nightly_20220120_33fa58400-builds-Win32-SSE2.zip (Mirror)

Code: [Select]
------------------------------------------------------------------------
commit 33fa58400
Author: Joshua Glatt
Commit: GitHub

    Remove unneeded/leaky code from sexp_list_item in FRED and QtFRED (#3942)
 fred2/sexp_tree.cpp                 | 64 ++++++++++---------------------------
 fred2/sexp_tree.h                   |  7 +---
 qtfred/src/ui/widgets/sexp_tree.cpp | 63 ++++++++++--------------------------
 qtfred/src/ui/widgets/sexp_tree.h   |  7 +---
 4 files changed, 36 insertions(+), 105 deletions(-)

------------------------------------------------------------------------
commit 160b75bd9
Author: Goober5000
Commit: Goober5000

    make clang happy
 code/cmdline/cmdline.cpp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

------------------------------------------------------------------------
commit a436d5f3d
Author: Goober5000
Commit: Goober5000

    remove redundant externs for clang
 code/mission/missionparse.h | 3 ---
 code/parse/sexp.h           | 3 ---
 2 files changed, 6 deletions(-)

------------------------------------------------------------------------
commit 6db1accdb
Author: Goober5000
Commit: Goober5000

    remove this because it is handled elsewhere, and because ships can have this flag without serving this role
 code/ship/ship.cpp | 4 ----
 1 file changed, 4 deletions(-)

------------------------------------------------------------------------
commit 9e149ff46
Author: Goober5000
Commit: Goober5000

    set the flag if a ship uses a Knossos warpin or warpout effect
 code/mission/missionparse.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

------------------------------------------------------------------------
commit 5562a4f68
Author: Taylor Richards
Commit: GitHub

    update ffmpeg support for 5.0+ API changes (#3939)
 code/cutscene/ffmpeg/FFMPEGDecoder.cpp | 58 ++++++++++++++++++++--------------
 code/cutscene/ffmpeg/internal.h        |  6 ++--
 code/sound/ffmpeg/FFmpegWaveFile.cpp   | 16 +++++++---
 code/sound/ffmpeg/FFmpegWaveFile.h     |  2 +-
 4 files changed, 49 insertions(+), 33 deletions(-)

------------------------------------------------------------------------
commit 32e119457
Author: Goober5000
Commit: Goober5000

    change int to bool
 code/fireball/fireballs.cpp   | 4 ++--
 code/fireball/fireballs.h     | 2 +-
 code/mission/missionparse.cpp | 4 ++--
 code/mission/missionparse.h   | 2 +-
 code/parse/sexp.cpp           | 6 +++---
 code/parse/sexp.h             | 2 +-
 code/ship/ship.cpp            | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)

------------------------------------------------------------------------
commit 83faf8de9
Author: Joshua Glatt
Commit: GitHub

    Remove unnecessary/leaky strdup() calls in sexp_list_item in FRED/QtFRED (#3940)
 fred2/sexp_tree.cpp                 | 4 ++--
 qtfred/src/ui/widgets/sexp_tree.cpp | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

------------------------------------------------------------------------
commit 35eca2ae5
Author: Goober5000
Commit: Goober5000

    allow 3d warp to be enabled from the table
 code/fireball/fireballs.cpp    | 12 +++++++++++-
 code/fireball/fireballs.h      |  2 ++
 code/fireball/warpineffect.cpp |  2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit eab2401e9
Author: Goober5000
Commit: Goober5000

    Cmdline_3dwarp is now Fireball_use_3d_warp, apparently
 code/cmdline/cmdline.cpp | 3 +--
 code/cmdline/cmdline.h   | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

------------------------------------------------------------------------
commit d0964d738
Author: Taylor Richards
Commit: Taylor Richards

    use proper return for invalid particle effect
 code/particle/ParticleManager.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit f2a99117a
Author: Taylor Richards
Commit: Taylor Richards

    always init path renderer
 code/graphics/2d.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit ca73b4fef
Author: Taylor Richards
Commit: Taylor Richards

    fix crash on standalone from weapon trail cleanup
 code/weapon/trails.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit e81ad7024
Author: Taylor Richards
Commit: Taylor Richards

    skip tracker init popup on standalone
 code/network/multi_fstracker.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

------------------------------------------------------------------------
commit 0ba94a554
Author: Taylor Richards
Commit: Taylor Richards

    fix memory leak from libpcp context (undocumented)
 code/network/multi_portfwd.cpp | 2 ++
 1 file changed, 2 insertions(+)

------------------------------------------------------------------------
commit d75174992
Author: Taylor Richards
Commit: Taylor Richards

    release model interp data on level close for standalones
 code/model/modelinterp.cpp | 28 +++++++++++++++++++++-------
 freespace2/freespace.cpp   |  8 ++++++++
 2 files changed, 29 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit 45b2d2a83
Author: Taylor Richards
Commit: Taylor Richards

    release memory from object update on level close
 code/network/multi_obj.cpp | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 code/network/multi_obj.h   |  2 ++
 freespace2/freespace.cpp   |  2 ++
 3 files changed, 50 insertions(+)

------------------------------------------------------------------------
commit 11d3348d6
Author: Taylor Richards
Commit: Taylor Richards

    enable/disable extra cmdline options for standalone
 freespace2/freespace.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

------------------------------------------------------------------------
commit a0769910f
Author: Taylor Richards
Commit: Taylor Richards

    free loaded models after mission on standalone
 freespace2/freespace.cpp | 4 ++++
 1 file changed, 4 insertions(+)

------------------------------------------------------------------------
commit 5e2a4c05a
Author: Taylor Richards
Commit: Taylor Richards

    make sure particles don't get processed on standalone
 code/particle/ParticleManager.cpp              | 50 ++++++++++++++------------
 code/particle/effects/SingleParticleEffect.cpp |  4 +++
 code/particle/particle.cpp                     | 11 ++++++
 code/weapon/weapons.cpp                        |  2 +-
 4 files changed, 44 insertions(+), 23 deletions(-)

------------------------------------------------------------------------
commit 422c20d39
Author: Taylor Richards
Commit: Taylor Richards

    avoid initializing stuff that standalones don't need
 code/graphics/2d.cpp     | 16 +++++++++-------
 freespace2/freespace.cpp |  8 +++++---
 2 files changed, 14 insertions(+), 10 deletions(-)

------------------------------------------------------------------------
commit 0a4d589c1
Author: Goober5000
Commit: Goober5000

    log whether command briefing is using scroll buttons
 code/missionui/missioncmdbrief.cpp | 1 +
 1 file changed, 1 insertion(+)

------------------------------------------------------------------------
commit 6ee6ddf49
Author: Taylor Richards
Commit: GitHub

    fix missing texture bug on standalone (#3937)
 code/bmpman/bmpman.cpp | 2 ++
 1 file changed, 2 insertions(+)

------------------------------------------------------------------------
commit 4ee84b71d
Author: Goober5000
Commit: Goober5000

    refactor some names
 code/io/timer.cpp        | 95 ++++++++++++++++++++++++------------------------
 code/io/timer.h          | 20 +++++-----
 freespace2/freespace.cpp | 20 +++++-----
 3 files changed, 69 insertions(+), 66 deletions(-)

------------------------------------------------------------------------
commit 9c7a9a1c2
Author: Goober5000
Commit: Goober5000

    patch a hole in the pausing and make sure timer pause/unpause is always called
 code/io/timer.cpp        |  2 ++
 freespace2/freespace.cpp | 16 ++++++++--------
 2 files changed, 10 insertions(+), 8 deletions(-)

------------------------------------------------------------------------
commit 73a408043
Author: Goober5000
Commit: Goober5000

    time compression now works
 code/io/timer.cpp | 38 ++++++++++++++++++++++++++++++--------
 1 file changed, 30 insertions(+), 8 deletions(-)

------------------------------------------------------------------------
commit 18f4f490d
Author: Goober5000
Commit: Goober5000

    time compression outline, static casts
 code/io/timer.cpp        | 54 +++++++++++++++++++++++++++---------------------
 code/io/timer.h          |  2 ++
 freespace2/freespace.cpp | 10 +++++++++
 3 files changed, 43 insertions(+), 23 deletions(-)

------------------------------------------------------------------------
commit 97f9aa225
Author: Goober5000
Commit: Goober5000

    move stuff here too
 code/io/timer.h | 79 +++++++++++++++++++++++++++++++--------------------------
 1 file changed, 43 insertions(+), 36 deletions(-)

------------------------------------------------------------------------
commit cf6a46042
Author: Goober5000
Commit: Goober5000

    move some stuff around
 code/io/timer.cpp | 214 +++++++++++++++++++++++++++---------------------------
 1 file changed, 107 insertions(+), 107 deletions(-)

------------------------------------------------------------------------
commit 00de4c3e7
Author: Goober5000
Commit: Goober5000

    timestamps should be running just about all the time
 code/io/timer.cpp        | 54 +++++++++++++++++++++++++++++++++++++++++------
 code/io/timer.h          |  7 +++++-
 code/menuui/credits.cpp  |  3 ---
 code/popup/popup.cpp     |  2 +-
 freespace2/freespace.cpp | 55 +++++++++++++++++++++++++++---------------------
 5 files changed, 85 insertions(+), 36 deletions(-)

------------------------------------------------------------------------
commit e3b4171f0
Author: Goober5000
Commit: Goober5000

    no need to keep Debug_dump_frames anymore
 freespace2/freespace.cpp | 28 +---------------------------
 1 file changed, 1 insertion(+), 27 deletions(-)

------------------------------------------------------------------------
commit a1dadb1c0
Author: Goober5000
Commit: Goober5000

    small refactor
 code/io/timer.cpp | 4 ++--
 code/io/timer.h   | 5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)

------------------------------------------------------------------------
commit 0dc3c914d
Author: Goober5000
Commit: Goober5000

    tweak the event music start so that missions will be consistent regardless of the player entry delay
 code/gamesnd/eventmusic.cpp         | 9 ++++++++-
 code/gamesnd/eventmusic.h           | 1 +
 code/scripting/api/libs/mission.cpp | 1 -
 freespace2/freespace.cpp            | 4 +++-
 4 files changed, 12 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit 8e33644a8
Author: Goober5000
Commit: Goober5000

    since we used to fast-forward at the rate of 1/4 second per frame, simulate the same thing with the timer
 code/io/timer.cpp        | 15 +++++++++++++++
 code/io/timer.h          |  4 ++++
 freespace2/freespace.cpp |  9 ++++++++-
 3 files changed, 27 insertions(+), 1 deletion(-)

------------------------------------------------------------------------
commit 12363fe18
Author: Goober5000
Commit: Goober5000

    qtfred
 qtfred/src/fredstubs.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 88f4163ae
Author: Goober5000
Commit: Goober5000

    always give the game priority when starting/stopping time
 code/io/timer.cpp        |  4 ++--
 code/io/timer.h          |  4 ++--
 fred2/fredstubs.cpp      |  2 +-
 freespace2/freespace.cpp | 18 ++++++++++--------
 freespace2/freespace.h   |  4 ++--
 test/src/test_stubs.cpp  |  2 +-
 6 files changed, 18 insertions(+), 16 deletions(-)

------------------------------------------------------------------------
commit 1b51225c5
Author: Goober5000
Commit: Goober5000

    convert the FSO timestamp system to use SDL time
 code/io/timer.cpp        | 105 +++++++++++++++++++++++++++++++++--------------
 code/io/timer.h          |  25 ++++++-----
 code/menuui/credits.cpp  |  10 +++--
 code/network/multi.cpp   |   3 --
 fred2/fredstubs.cpp      |   2 +-
 freespace2/freespace.cpp |  84 ++++++++++++++++++-------------------
 freespace2/freespace.h   |   2 +-
 test/src/test_stubs.cpp  |   2 +-
 8 files changed, 139 insertions(+), 94 deletions(-)

 

Offline Antares

  • 28
  • Author of The Shivan Manifesto
Re: Nightly: 20 January 2022 - Revision 33fa58400
Some wonky timing issues with this build for sure. The first time I played Last Hope in FSPort, the mission loaded with the Hope already in-system (it normally jumps in after 10 or 15 seconds); the second time I played, the Hope jumped in as soon as the mission started.

Note that restarting the mission seems to fix whatever's going on, as things happen normally; to play around with it, load another mission, then load Last Hope.
We have returned to continue our purification of this galaxy. It is again your turn to be crushed beneath the great force that is the Antaran army. All your petty squabbling with the other beings in this galaxy is meaningless. The Antaran fleet will destroy you all, one by one. You may not surrender. You cannot win. Your only option is death.

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Re: Nightly: 20 January 2022 - Revision 33fa58400
Are you sure you have the correct build selected?  I tested the mission with the current source code and the Hope is delayed as expected.

 

Offline taylor

  • Super SCP/Linux Guru
  • Moderator
  • 212
    • http://www.icculus.org/~taylor
Re: Nightly: 20 January 2022 - Revision 33fa58400
For me it jumped in after about 14-15 seconds a couple of times and ~25 all the rest of the times. The 14-15 second time generally happened with a fresh game load and the first mission played. And it was consistently ~25 seconds with a restart.

I didn't check the mission to determine what time it's actually supposed to show up so I'm not sure which number is wrong.

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Re: Nightly: 20 January 2022 - Revision 33fa58400
The correct time is 25 seconds.  I was able to get this consistently whether it was the first thing I did after starting the game, or I restarted the mission, or I played a different mission first.

I did see it jump in earlier once, but I think I had tabbed away from the window during that session.  I wonder if the time might not be getting paused correctly when the game loses focus.

 

Offline taylor

  • Super SCP/Linux Guru
  • Moderator
  • 212
    • http://www.icculus.org/~taylor
Re: Nightly: 20 January 2022 - Revision 33fa58400
The earlier jump time happened about 1 in 9 tries in my tests, so it wasn't easily reproducible. I'll do some additional testing and see if I can narrow down something that will help explain or better debug this.

 

Offline Antares

  • 28
  • Author of The Shivan Manifesto
Re: Nightly: 20 January 2022 - Revision 33fa58400
Gotcha.

Ten seconds:



Five seconds:



In the process of jumping in when the mission loaded:



Believe it or not, this might have something to do with ship selection and/or loadout. That's the only thing I've been changing.

EDIT: No, scratch that. After further investigation, I think what's happening here is that the mission clock actually starts running during the mission briefing, not the mission itself. I've noticed some odd behavior in other missions, like starting far away from other ships that are already engaged in combat, and I think it's because the mission actually begins when the briefing starts--running underneath the briefing itself--so while you're listening to the briefing and choosing your loadout, time is ticking away and your wingmen are already mixing it up. That's why restarting the mission fixes things: it resets the mission timer to zero (and skips the briefing entirely) so everything runs normally.
« Last Edit: January 21, 2022, 02:11:44 am by Antares »
We have returned to continue our purification of this galaxy. It is again your turn to be crushed beneath the great force that is the Antaran army. All your petty squabbling with the other beings in this galaxy is meaningless. The Antaran fleet will destroy you all, one by one. You may not surrender. You cannot win. Your only option is death.

 

Offline wookieejedi

  • 29
  • Intensify Forward Firepower
Re: Nightly: 20 January 2022 - Revision 33fa58400
Great catch on the briefing. Can confirm on my end, too.

 

Offline taylor

  • Super SCP/Linux Guru
  • Moderator
  • 212
    • http://www.icculus.org/~taylor
Re: Nightly: 20 January 2022 - Revision 33fa58400
Confirmed here too.

Edit: Adding to that, I waited over a minute at the briefing and when I entered the mission the Hope was already there and off to my left and the Shivans were in mission too.
« Last Edit: January 21, 2022, 07:21:47 am by taylor »

 

Offline Trivial Psychic

  • 212
  • Snoop Junkie
Re: Nightly: 20 January 2022 - Revision 33fa58400
I'm no coder, but could this change have something to do with it?
Code: [Select]
convert the FSO timestamp system to use SDL time
The Trivial Psychic Strikes Again!

 

Offline taylor

  • Super SCP/Linux Guru
  • Moderator
  • 212
    • http://www.icculus.org/~taylor
Re: Nightly: 20 January 2022 - Revision 33fa58400
I'm no coder, but could this change have something to do with it?
Code: [Select]
convert the FSO timestamp system to use SDL time

Yes, but it does have conditions to compensate for this issue. Those conditions appear to be working but not having the proper affect here for some reason.

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Re: Nightly: 20 January 2022 - Revision 33fa58400