Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Goober5000 on August 17, 2007, 09:41:54 pm

Title: SCP bug hunting drive! Calling all programmers!
Post by: Goober5000 on August 17, 2007, 09:41:54 pm
This is something taylor and I have discussed informally, and I think it's time to give it a shot.  Announcing the first-ever community-for-hire bug-hunting drive.  The rules are simple:

1) Look on Mantis (http://scp.indiegames.us/mantis), find a bug that isn't assigned to anybody (or if it is assigned to somebody, ask if you can steal it) and claim it in this thread.  I will reassign it to the "bug_hunting_drive" user, so that people know it's been claimed.

2) Fix it, and submit a patch (or explain why it isn't a bug).

3) Earn bounties.  For each issue that's a bona fide bug, you get $5.  (Particularly evil bugs may be worth more, at sponsor's discretion.)  For each issue that's a configuration problem or a user error, you get $1.

The drive will run until September 30th and is open to anybody who isn't wearing a SCP avatar.  The bounties will be sponsored by me, at least initially.  Payment will be via PayPal or by special arrangement.

The purposes of the drive are twofold.  First, to get bugs fixed in Mantis, as a lot of the existing SCP staff are either busy, burned out, or slacking off.  Second, to get more people interested in the SCP, some of which will hopefully decide to join.

What are you waiting for?  Get going! :)
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Polpolion on August 17, 2007, 10:08:24 pm
I'd do it for free if I knew how to program :(.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Turey on August 17, 2007, 10:12:39 pm
and is open to anybody who isn't wearing a SCP avatar.

Damn it!
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: haloboy100 on August 17, 2007, 10:47:49 pm
I'd do it for free if I knew how to program :(.

Damnit, me too. Well, where can i learn to program, as in video game wise? what program and what tutorial should i look at?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: CP5670 on August 17, 2007, 11:06:32 pm
I know some C but hardly know anything about the FS2 code or game programming in general. You best bet for this might be some of those "slacking off" coders who are already part of the SCP. :p
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Goober5000 on August 17, 2007, 11:14:48 pm
I'd do it for free if I knew how to program :(.
So maybe this will be an incentive to learn. :)


You best bet for this might be some of those "slacking off" coders who are already part of the SCP. :p
Uh, no.  Part of the responsibility of being a SCP member includes fixing bugs on a regular basis.  If we included members of the SCP, it would almost be a vindication of doing nothing the rest of the time.

Any one of the SCP staff that doesn't bug fix, and yet still contributes code to CVS, should be in danger of having their membership revoked.  That's the theoretical basis for membership in the first place.  We haven't enforced it before, but I'm leaning more and more toward doing so.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: CP5670 on August 17, 2007, 11:23:57 pm
I see where you're coming from there. What I meant is that most of the existing programmer talent around here is already affiliated with the SCP in some way, and the rest of us don't really have the necessary knowledge. Maybe I'll take a closer look at the code and see if I can make any sense of it.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Polpolion on August 17, 2007, 11:32:52 pm
I'd do it for free if I knew how to program :(.
So maybe this will be an incentive to learn. :)

I'm learning, but I started out to advanced and now I am confused and have to start all over. :blah:

My goal is to not have to do anything when my semester of C programing class comes around in the spring :drevil:. Then I have to suffer through an advanced placement java class, then I can really start learning good C++. Hopefully, though, I'll get to the point where I can just look at some code and sorta pick it up as I go before then.

*goes off to read Kernighan and Ritchie.


Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Grizzly on August 18, 2007, 02:22:03 am
Did people give to much donations?

Anyway, I am not going to fix the bugs... just report them.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: jr2 on August 18, 2007, 03:53:05 am
@Goober: Could you maybe find a coder forum and buy some of their AdSense?  XD  IDK, Wing Commander guys seemed to have done that on our site b4... *shrugs*
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: akenbosch on August 18, 2007, 04:10:13 pm
i'll give it a try, but first i need the source code.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: karajorma on August 18, 2007, 05:47:36 pm
Knock yourself out

http://www.hard-light.net/forums/index.php/topic,41234.msg842224.html#msg842224
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: jr2 on August 18, 2007, 06:27:32 pm
You should've linked to the wiki (http://www.hard-light.net/forums/index.php/topic,41234.msg993572.html#msg993572).  (kara must clicky the link.  :hopping: )
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: karajorma on August 18, 2007, 06:40:14 pm
The wiki page doesn't have pictures. :)
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: akenbosch on August 18, 2007, 06:43:14 pm
parents sya "no downloading with some weird program" because "its virus ridden".

is it possilbe for a zip file to be uploaded?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: jr2 on August 18, 2007, 06:44:35 pm
Good gravy.  http://free.grisoft.com
Get yourself an Anti-Virus scanner and stop worrying.  (It's free.)  While you're at it, get the Anti-Spam software, too.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: akenbosch on August 18, 2007, 07:01:40 pm
yeah, we have one. "the virus might be newer than the virus library". paranoia.... :doubt:

only zips available are the btrl build and the retail code.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: StarSlayer on August 18, 2007, 07:07:50 pm
Good gravy.  http://free.grisoft.com
Get yourself an Anti-Virus scanner and stop worrying.  (It's free.)  While you're at it, get the Anti-Spam software, too.

Anti-Spam software might block his ability to post :P
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Shade on August 18, 2007, 07:08:22 pm
Providing zips for the post-retail code would be a logistical nightmare, as it is constantly changing. Would need to re-upload the thing sometimes 4-5 times a day to keep it current. But if you're interested in specific parts of the code, there's still the online version of the CVS Repository (http://fs2source.warpcore.org/cgi-bin/cvsweb/cvsweb.cgi/) which is updated automatically. Would take you a long, long time to get every file from there though.

Just tell your parents that tortoise CVS isn't a virus :p
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: akenbosch on August 18, 2007, 09:19:42 pm
aye...parents are annoying. they want a long detailed post from the person who uses it most (goober?).
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: chief1983 on August 18, 2007, 10:46:17 pm
For crap's sake...Tortoise is a common program used by thousands of developers, and the source code isn't anything but TEXT FILES!  (well, a couple libs...) You can read them yourself!  It's monitored by dozens of developers who are constantly working on it, and the oversight and commit logs would show anything that someone slipped in (I hope...).  That's the whole point of open source being more secure than closed source, the oversight.  Jeez, your parents are at more of a risk having a Windows PC on the internet in the first place than downloading and running the FS source.  How's that for a detailed post?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: CP5670 on August 18, 2007, 11:31:02 pm
It doesn't matter. It's not like he is going to do anything with the code anyway. :p
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Mars on August 18, 2007, 11:46:06 pm
You can always rebel you know akenbosch
It doesn't matter. It's not like he is going to do anything with the code anyway. :p
I think we all saw that one coming.

Is there an online C++ tutorial y'all would recommend?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: jr2 on August 19, 2007, 01:11:23 am
yeah, we have one. "the virus might be newer than the virus library". paranoia.... :doubt:

only zips available are the btrl build and the retail code.

Umm, AVG Anti-Virus is one of the most updated AV software there is.  Catches stuff Snortin' Norton and MchackAfee don't catch.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: karajorma on August 19, 2007, 02:56:15 am
only zips available are the btrl build and the retail code.

So use the BtRL code. It's basically 3.6.9 Official.

Look for very old bugs.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Shade on August 19, 2007, 04:37:25 am
Quote
Is there an online C++ tutorial y'all would recommend?
http://www.cprogramming.com/tutorial.html
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: pecenipicek on August 25, 2007, 09:56:32 am
also, what does one need except the tortoisecvs for getting started with the code?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Turey on August 25, 2007, 02:21:56 pm
also, what does one need except the tortoisecvs for getting started with the code?

http://winmerge.org/

Also, a compiler helps a lot.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Grizzly on August 25, 2007, 02:59:26 pm
only zips available are the btrl build and the retail code.

So use the BtRL code. It's basically 3.6.9 Official.

Look for very old bugs.

Do people get an bonus for fixing the Red Alert bug?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: taylor on August 25, 2007, 05:47:14 pm
Do people get an bonus for fixing the Red Alert bug?
HOLY **** dude!  How many times do we have to say that the damn thing was fixed MONTHS AGO!!!!
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: akenbosch on August 30, 2007, 01:30:35 pm
Do we get a bonus for fixing the "cant read model file: none" in -wep.tbms?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: taylor on August 30, 2007, 02:30:55 pm
Do we get a bonus for fixing the "cant read model file: none" in -wep.tbms?
I think that one is already fixed actually, but perhaps only in my Xt builds at the moment.  I think that there is a Mantis bug relating to this, in an obscure way at least, which I had already commented on.  I don't see a related change in my diff though, so it's either already committed to CVS, or I fixed a similar problem for ships and forgot about weapons.


But if you guys want bugs to fix then just go through Mantis.  If you have a bug that's not in Mantis then add it.  But don't just make up bugs to fix as part of this bug hunt, fix something that we really need fixed.  Please.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: akenbosch on August 30, 2007, 02:51:21 pm
like the d3d code?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: taylor on August 30, 2007, 03:54:36 pm
like the d3d code?
I think that someone is already working on that actually.

But there are 204 open bugs in Mantis at the moment, 59 of those not being assigned to anyone.  We've got everything ranging from a major rewrite to a small tweak, so there should be something fixable by a coder of just about any experience level.  Just have a look at the ones that aren't assigned to anyone.  If none of those peak your interest then have a look at ones that are assigned to someone, ask them if you can take care of it instead, and then go about fixing it.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: chief1983 on August 30, 2007, 04:44:33 pm
Is there an official code freeze for the stable branch while this bug drive is going on?  It would probably help.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: karajorma on August 31, 2007, 08:15:27 am
Any new code added to the stable branch should either be a very heavily tested new feature or a bug fix.

So an actual freeze shouldn't be needed.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: taylor on August 31, 2007, 01:52:33 pm
Technically the stable branch is in a feature freeze actually.  Nothing should be going in, new feature wise, unless it was already slated for 3.6.10 months ago.  3.6.10 was supposed to ship in July, so it's far too late to just start shoving stuff in now without a very good reason.  There will be exceptions, but don't assume that anything new is safe to commit, regardless of how tested and stable it might be.  Those things should be pushed to 3.6.11 instead.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: DaBrain on September 02, 2007, 02:18:14 pm
If this works and you prolong it, you should think about working out some kind of donation system.

I'd probably spend a few bucks to get some bugs fixed. ;)
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: KeldorKatarn on September 04, 2007, 02:00:37 am
Bug in vecmat.cpp:

Comment mentions the third paramter can be NULL, but never checks for it and always tries to normalize it.
If this function is used with the third paramter being NULL, the game crashes.
I'll ask Backslash to commit this fix so no need for someone else to do it. Just wanted to mention this here, in case someone
might find out that this was actually causing some crashes that haven't been explained yet...

Code: [Select]
//computes the delta angle between two vectors.
//vectors need not be normalized. if they are, call vm_vec_delta_ang_norm()
//the forward vector (third parameter) can be NULL, in which case the absolute
//value of the angle in returned.  Otherwise the angle around that vector is
//returned.
float vm_vec_delta_ang(vec3d *v0,vec3d *v1,vec3d *fvec)
{
float t;
vec3d t0,t1,t2;

vm_vec_copy_normalize(&t0,v0);
vm_vec_copy_normalize(&t1,v1);

  // This test here is new and was missing. Function tried to always normalize fvec which used to cause a crash.
  if (NULL == fvec) {
    t = vm_vec_delta_ang_norm(&t0, &t1, NULL);
  } else {
    vm_vec_copy_normalize(&t2,fvec);
    t = vm_vec_delta_ang_norm(&t0,&t1,&t2);
  }

return t;
}
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: taylor on September 04, 2007, 06:38:50 am
Bug in vecmat.cpp:

Comment mentions the third paramter can be NULL, but never checks for it and always tries to normalize it.
If this function is used with the third paramter being NULL, the game crashes.
I'll ask Backslash to commit this fix so no need for someone else to do it. Just wanted to mention this here, in case someone
might find out that this was actually causing some crashes that haven't been explained yet...
That function isn't used anywhere.  I've been meaning to just remove it, but haven't really cared enough to go through the trouble yet.

The _norm() version of that function should be used instead, and with that one it is safe to have fvec as NULL.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: IPAndrews on September 04, 2007, 07:06:00 am
Quote from: taylor link=topic=48968.msg996199#msg996199
HOLY **** dude!  How many times do we have to say that the damn thing was fixed MONTHS AGO!!!!
[/quote

  :lol: @ comically over-the-top reaction.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: taylor on September 04, 2007, 07:14:17 am
Quote from: taylor
HOLY **** dude!  How many times do we have to say that the damn thing was fixed MONTHS AGO!!!!

  :lol: @ comically over-the-top reaction.
Our previous 15-20 responses of "Yes, the redalert bug has been fixed and will be resolved in 3.6.10." didn't seem to be doing the trick, so I thought that I'd try something a little different this time. ;)
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: KeldorKatarn on September 04, 2007, 07:46:44 am
Bug in vecmat.cpp:

Comment mentions the third paramter can be NULL, but never checks for it and always tries to normalize it.
If this function is used with the third paramter being NULL, the game crashes.
I'll ask Backslash to commit this fix so no need for someone else to do it. Just wanted to mention this here, in case someone
might find out that this was actually causing some crashes that haven't been explained yet...
That function isn't used anywhere.  I've been meaning to just remove it, but haven't really cared enough to go through the trouble yet.

The _norm() version of that function should be used instead, and with that one it is safe to have fvec as NULL.

Well.. I am using it in a new feature I implemented .. so please keep it *g* besides.. with this change it works perfectly well and one doesn't have to normalize all input vectors manually first
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Alan Bolte on September 15, 2007, 08:48:14 am
Not to necro or anything, but did this get any serious bites?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Turey on September 15, 2007, 12:10:25 pm
Not to necro or anything, but did this get any serious bites?

Not that I know of.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Goober5000 on September 15, 2007, 08:13:12 pm
None whatsoever.

KeldorKatarn has a good shot at earning some cash here, since he wasn't a SCP member when this started, but he hasn't asked for any Mantis bugs to be assigned to him yet.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: jr2 on September 16, 2007, 01:43:49 am
I see they're offering a one dollar bounty on bugs.

I could post on elance.com and get some programmers in India to fix them for 25 cents apiece.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Goober5000 on September 16, 2007, 01:39:36 pm
Well, if he posted about it, I haven't heard anything.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: jr2 on September 16, 2007, 02:36:45 pm
Well, if he posted about it, I haven't heard anything.

He didn't.  That's a quote from a PM.

Well?  :)
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Goober5000 on September 16, 2007, 06:54:35 pm
Well I won't hear anything unless he posts, will I? :p
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Mongoose on September 16, 2007, 07:00:21 pm
If I had a compiler installed and CVS set up and knew what the heck I was doing, I might have taken a shot at this, money or no money; those three semesters of C/C++ classes have to have been worth something.  I don't know that I'd have the time now to do anything serious, but having that option would be nice.  Maybe one of these days I'll look into it.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Goober5000 on September 30, 2007, 02:24:41 pm
It's September 30th and so far we've had a grand total of 0 Mantis bugs fixed on account of the drive. :doubt:
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Turey on September 30, 2007, 02:38:30 pm
It's September 30th and so far we've had a grand total of 0 Mantis bugs fixed on account of the drive. :doubt:

 :(

I've fixed several bugs on my own in that time, though.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Mongoose on September 30, 2007, 04:36:14 pm
Hey, I've been doing my utmost to get this CVS bit up and running and start poking around, but after apparently being completely stymied with Cygwin, I'll have to give something else a shot before I can get going. :p
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Goober5000 on September 30, 2007, 05:45:48 pm
:(

I've fixed several bugs on my own in that time, though.
Indeed you have.  Maybe I should amend the contest to include SCP members who joined less than one year ago...
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: jr2 on October 01, 2007, 02:06:54 am
You been putting Google ads on developer sites?  ;7  And what about StumbleUpon...  ;)
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: CP5670 on October 03, 2007, 12:41:31 am
It's September 30th and so far we've had a grand total of 0 Mantis bugs fixed on account of the drive. :doubt:

I was always expecting that given the current rules on who can participate. It might be better to just reward anyone who fixes bugs, regardless of their SCP affiliation.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: karajorma on October 03, 2007, 01:50:49 am
Yeah but if Taylor started up again you'd probably be paying him an actual wage. :D
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: blackhole on October 03, 2007, 01:52:54 am
Since its not a secret anymore, I helped taylor fix a few bugs in the GLSL shader code. I can't actually recieve donations, so its rather null, but i was just wondering if it counted...?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: karajorma on October 03, 2007, 02:52:30 am
Well it's appreciated for certain but technically I don't think it would count since the bugs weren't in Mantis and were for a new feature.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: blackhole on October 03, 2007, 02:58:12 am
Oh poo, well, glad i could help anyway :D
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: CiberWizZ on October 11, 2007, 05:39:00 pm
Hi, can't go to mantis  :confused: PHP error?

;)
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: colecampbell666 on October 13, 2007, 04:05:50 pm
I tried to advertise this on GameSpot and they deleted it and threatened to ban me for spam.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: jr2 on October 13, 2007, 04:11:00 pm
Welcome to my world... :(  n00bs abound out there.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: colecampbell666 on October 13, 2007, 04:43:45 pm
We're a tiny corner of sanity in the universe of the intarwebz.
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: Turey on October 13, 2007, 04:56:04 pm
woah unstickied?
Title: Re: SCP bug hunting drive! Calling all programmers!
Post by: colecampbell666 on October 13, 2007, 05:14:52 pm
It got no big hits.