Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Flaming_Sword on September 18, 2009, 08:15:03 pm

Title: Whitespace Nuking Patches
Post by: Flaming_Sword on September 18, 2009, 08:15:03 pm: Just for the hell of it (because I *really* hate trailing whitespace):

Trailing whitespace is trimmed, leading spaces are tabified.

Contains patches for Trunk and Antipodes.

http://www.mediafire.com/?vjyozglmidj
Title: Re: Whitespace Nuking Patches
Post by: castor on September 19, 2009, 05:05:11 am: I guess a commit like that needs to be co-ordinated well? (to not despair anyone with uncommitted big edits)
Title: Re: Whitespace Nuking Patches
Post by: portej05 on September 19, 2009, 08:48:55 am: That, and this patch'll be out of date after the next commit :P
Title: Re: Whitespace Nuking Patches
Post by: chief1983 on September 19, 2009, 09:06:21 am: It does not remove any intentional trailing whitespace? There must be a place or two where something wrapped and the whitespace isn't meaningless?
Title: Re: Whitespace Nukin' Patches
Post by: Aardwolf on September 19, 2009, 04:09:01 pm: So, what is this, a massive patch trimming all of the whitespace in the entire project?
Title: Re: Whitespace Nukin' Patches
Post by: Flaming_Sword on September 19, 2009, 04:48:32 pm: Quote from: chief1983 on September 19, 2009, 09:06:21 am
It does not remove any intentional trailin' whitespace? There must be a place or two where somethin' wrapped an' th' whitespace isn't meaningless?

I would've thought that that every line would end with a semicolon or a slash (or even a comment).

Quote from: Aardwolf on September 19, 2009, 04:09:01 pm
So, what is this, a massive patch trimming all of the whitespace in the entire project?

Yes.

There's always the alternative of whitespace being nuked in my future patches/commits. :nervous:
Title: Re: Whitespace Nuking Patches
Post by: karajorma on September 19, 2009, 09:27:18 pm: To be honest I'm against this kind of housekeeping patch because it makes Blame virtually useless.
Title: Re: Whitespace Nuking Patches
Post by: portej05 on September 20, 2009, 12:08:33 am: Quote from: karajorma on September 19, 2009, 09:27:18 pm
To be honest I'm against this kind of housekeeping patch because it makes Blame virtually useless.

That's why SVN lets you view individual file histories and you can stick a range limit on Blame
Means that the commit comments need to be useful, but if they're not, it's still fairly simple to work through