Author Topic: Whitespace Nuking Patches  (Read 2531 times)

0 Members and 1 Guest are viewing this topic.

Whitespace Nuking Patches
Just for the hell of it (because I *really* hate trailing whitespace):

Trailing whitespace is trimmed, leading spaces are tabified.

Contains patches for Trunk and Antipodes.

http://www.mediafire.com/?vjyozglmidj

 

Offline castor

  • 29
    • http://www.ffighters.co.uk./home/
Re: Whitespace Nuking Patches
I guess a commit like that needs to be co-ordinated well? (to not despair anyone with uncommitted big edits)

 
Re: Whitespace Nuking Patches
That, and this patch'll be out of date after the next commit :P
STRONGTEA. Why can't the x86 be sane?

  

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: Whitespace Nuking Patches
It does not remove any intentional trailing whitespace?  There must be a place or two where something wrapped and the whitespace isn't meaningless?
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Aardwolf

  • 211
  • Posts: 16,384
Re: Whitespace Nukin' Patches
So, what is this, a massive patch trimming all of the whitespace in the entire project?

 
Re: Whitespace Nukin' Patches
It does not remove any intentional trailin' whitespace?  There must be a place or two where somethin' wrapped an' th' whitespace isn't meaningless?

I would've thought that that every line would end with a semicolon or a slash (or even a comment).

So, what is this, a massive patch trimming all of the whitespace in the entire project?

Yes.

There's always the alternative of whitespace being nuked in my future patches/commits. :nervous:

 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: Whitespace Nuking Patches
To be honest I'm against this kind of housekeeping patch because it makes Blame virtually useless.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]

 
Re: Whitespace Nuking Patches
To be honest I'm against this kind of housekeeping patch because it makes Blame virtually useless.

That's why SVN lets you view individual file histories and you can stick a range limit on Blame
Means that the commit comments need to be useful, but if they're not, it's still fairly simple to work through
STRONGTEA. Why can't the x86 be sane?