[SirKnightly]

Here is the nightly for 23 August 2016 - Revision eb086da


Group: Linux
nightly_20160823_eb086da-builds-Linux.tar.gz
SHA1: d9e4d01b8ec947b9722bd87b07ab5ec049e6e8d9


Group: MacOSX
nightly_20160823_eb086da-builds-MacOSX.tar.gz
SHA1: aa6f5e873d0862de84df2b74e1ca3fb14b2bf707


Group: Win32
nightly_20160823_eb086da-builds-Win32.zip
SHA1: 1ffcc82b1eefc6d09678a97a50f6826a7af66e92

Code: [Select]

------------------------------------------------------------------------
commit 50c22d9
Author: Fabian Woltermann <Mon Aug 22 20:30:53 2016 +0200>
Commit: Fabian Woltermann <Mon Aug 22 20:30:53 2016 +0200>

    Fixes breaking issues in subsystem memory management
 code/ship/ship.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit adcc332
Author: Fabian Woltermann <Mon Aug 22 13:33:13 2016 +0200>
Commit: Fabian Woltermann <Mon Aug 22 13:33:13 2016 +0200>

    Addressing some feedback
 code/model/modelread.cpp | 10 ++++++----
 code/ship/ship.cpp       | 11 ++++++-----
 code/ship/ship.h         |  2 +-
 3 files changed, 13 insertions(+), 10 deletions(-)

------------------------------------------------------------------------
commit 043c1ae
Author: asarium <Mon Aug 22 11:17:32 2016 +0200>
Commit: asarium <Mon Aug 22 11:17:32 2016 +0200>

    Fix heap overflow reported by AddressSanitizer
 code/graphics/software/font.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit 4ec4de1
Author: z64555 <Sat Aug 20 08:32:16 2016 -0500>
Commit: z64555 <Sun Aug 21 18:42:11 2016 -0500>

    Moves player_set_padlock_state()'s code into do_view_slew() and deletes player_set_padlock_state(); * Moves a camera lock statement into do_view_chase() to coincide with do_view_slew()'s style; * Resets camera angles when transitioning into chase and external views from target padlock view;
 code/playerman/playercontrol.cpp | 116 ++++++++++++++++++++++-----------------
 1 file changed, 66 insertions(+), 50 deletions(-)

------------------------------------------------------------------------
commit 9bce334
Author: z64555 <Thu Aug 18 01:54:03 2016 -0500>
Commit: z64555 <Sun Aug 21 18:41:07 2016 -0500>

    Move Padlock view angle modification to view_modify()
 code/playerman/playercontrol.cpp | 45 +++++++++++++++++++++++++---------------
 1 file changed, 28 insertions(+), 17 deletions(-)

------------------------------------------------------------------------
commit c74eb9a
Author: asarium <Fri Aug 19 23:58:09 2016 +0200>
Commit: asarium <Sun Aug 21 16:54:07 2016 +0200>

    Enable cotire by default for Visual Studio
 CMakeLists.txt             | 10 +++++--
 cmake/toolchain-msvc.cmake | 38 ++++++++++++------------
 cmake/util.cmake           |  7 +----
 code/sound/acm.cpp         | 72 ++++++++++++++++++++++------------------------
 4 files changed, 63 insertions(+), 64 deletions(-)

------------------------------------------------------------------------
commit c57e59d
Author: Fabian Woltermann <Sat Aug 20 20:42:22 2016 +0200>
Commit: Fabian Woltermann <Sat Aug 20 20:42:22 2016 +0200>

    Addressing feedback
 code/ai/ai_profiles.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit c72376b
Author: Fabian Woltermann <Fri Aug 19 22:54:42 2016 +0200>
Commit: Fabian Woltermann <Fri Aug 19 22:54:42 2016 +0200>

    Fix compilation
 code/ship/ship.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit 0591b7e
Author: Fabian Woltermann <Fri Aug 19 22:44:39 2016 +0200>
Commit: Fabian Woltermann <Fri Aug 19 22:44:39 2016 +0200>

    ai profile flags
 code/ai/ai.h                        |   9 +-
 code/ai/ai_flags.h                  | 104 +++++++++----------
 code/ai/ai_profiles.cpp             | 193 ++++++++++++++++++++++--------------
 code/ai/ai_profiles.h               |  11 +-
 code/ai/aibig.cpp                   |   6 +-
 code/ai/aicode.cpp                  | 122 +++++++++--------------
 code/ai/aiturret.cpp                |  26 ++---
 code/hud/hudobserver.cpp            |   2 +-
 code/hud/hudtarget.cpp              |   4 +-
 code/mission/missiongoals.cpp       |   2 +-
 code/mission/missionparse.cpp       |   2 +-
 code/network/multiteamselect.cpp    |   4 +-
 code/object/collideweaponweapon.cpp |   4 +-
 code/object/objectshield.cpp        |   2 +-
 code/physics/physics.cpp            |   2 +-
 code/ship/ship.cpp                  |  14 +--
 code/ship/shiphit.cpp               |   4 +-
 code/stats/scoring.cpp              |   6 +-
 code/weapon/beam.cpp                |   6 +-
 code/weapon/weapons.cpp             |  12 +--
 freespace2/freespace.cpp            |   2 +-
 21 files changed, 279 insertions(+), 258 deletions(-)

------------------------------------------------------------------------
commit 9942bf7
Author: Fabian Woltermann <Fri Aug 19 21:12:21 2016 +0200>
Commit: Fabian Woltermann <Fri Aug 19 21:12:21 2016 +0200>

    Add to cmake
 code/source_groups.cmake | 1 +
 1 file changed, 1 insertion(+)

------------------------------------------------------------------------
commit 1471cfa
Author: Fabian Woltermann <Fri Aug 19 21:11:57 2016 +0200>
Commit: Fabian Woltermann <Fri Aug 19 21:11:57 2016 +0200>

    Adds ai_flags master file
 code/ai/ai_flags.h | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 119 insertions(+)

------------------------------------------------------------------------
commit 90a2644
Author: Fabian Woltermann <Fri Aug 19 21:08:14 2016 +0200>
Commit: Fabian Woltermann <Fri Aug 19 21:08:14 2016 +0200>

    More cleanup
 code/ship/ship.cpp | 23 +++++++++++------------
 code/ship/ship.h   |  2 +-
 2 files changed, 12 insertions(+), 13 deletions(-)

------------------------------------------------------------------------
commit 6a1aa4c
Author: Fabian Woltermann <Fri Aug 19 20:59:01 2016 +0200>
Commit: Fabian Woltermann <Fri Aug 19 20:59:01 2016 +0200>

    More cleanup
 code/hud/hud.cpp         |  4 ++--
 code/hud/hud.h           |  2 +-
 code/model/model.h       |  2 +-
 code/model/modelread.cpp | 22 +++-------------------
 code/ship/ship.cpp       |  2 +-
 code/ship/ship.h         |  2 +-
 6 files changed, 9 insertions(+), 25 deletions(-)

------------------------------------------------------------------------
commit 9f27973
Author: Fabian Woltermann <Fri Aug 19 19:23:55 2016 +0200>
Commit: Fabian Woltermann <Fri Aug 19 19:23:55 2016 +0200>

    Fixes various bugs
 code/ai/aigoals.cpp           |  2 +-
 code/hud/hud.cpp              |  2 +-
 code/hud/hudtargetbox.cpp     |  2 +-
 code/mission/missionlog.cpp   |  2 +-
 code/mission/missionparse.cpp |  4 +-
 code/missionui/redalert.cpp   |  2 +-
 code/model/model.h            | 12 ++++--
 code/model/modelinterp.cpp    |  4 +-
 code/model/modelread.cpp      | 26 ++++++-------
 code/parse/sexp.cpp           | 14 +++----
 code/ship/ship.cpp            | 89 ++++++++++++++++++++++---------------------
 code/ship/ship.h              |  2 +-
 code/ship/shipfx.cpp          |  4 +-
 code/ship/shiphit.cpp         |  6 +--
 code/weapon/weapons.cpp       |  9 +----
 fred2/fredrender.cpp          |  4 +-
 fred2/initialstatus.cpp       |  2 +-
 fred2/sexp_tree.cpp           | 10 ++---
 fred2/shipgoalsdlg.cpp        |  2 +-
 fred2/weaponeditordlg.cpp     |  2 +-
 20 files changed, 101 insertions(+), 99 deletions(-)

------------------------------------------------------------------------
commit 1acfaa8
Author: Fabian Woltermann <Fri Aug 19 14:59:15 2016 +0200>
Commit: Fabian Woltermann <Fri Aug 19 14:59:15 2016 +0200>

    Converts model subsystem flags
 code/ai/aicode.cpp               |   2 +-
 code/ai/aigoals.cpp              |   2 +-
 code/ai/aiturret.cpp             |  52 ++++----
 code/hud/hud.cpp                 |   8 +-
 code/hud/hud.h                   |   2 +-
 code/hud/hudtargetbox.cpp        |   2 +-
 code/lab/lab.cpp                 |   4 +-
 code/mission/missionlog.cpp      |  14 +-
 code/mission/missionlog.h        |  10 +-
 code/mission/missionparse.cpp    |   8 +-
 code/mission/missionparse.h      |   2 +-
 code/missionui/redalert.cpp      |   2 +-
 code/model/model.h               |  70 ++--------
 code/model/model_flags.h         |   8 +-
 code/model/modelanim.cpp         |  10 +-
 code/model/modelanim.h           |   2 +-
 code/model/modelinterp.cpp       |   4 +-
 code/model/modelread.cpp         | 148 +++++++++++++++++----
 code/object/collideshipship.cpp  |   2 +-
 code/parse/lua.cpp               |  15 +--
 code/parse/sexp.cpp              |  24 ++--
 code/playerman/playercontrol.cpp |   5 -
 code/ship/awacs.cpp              |   2 +-
 code/ship/ship.cpp               | 279 +++++++++++++++++----------------------
 code/ship/ship.h                 |  11 +-
 code/ship/shipfx.cpp             |   6 +-
 code/ship/shiphit.cpp            |  12 +-
 code/weapon/beam.cpp             |  18 +--
 code/weapon/swarm.cpp            |   2 +-
 code/weapon/weapons.cpp          |   2 +-
 fred2/fredrender.cpp             |   4 +-
 fred2/initialstatus.cpp          |   4 +-
 fred2/sexp_tree.cpp              |  16 +--
 fred2/shipgoalsdlg.cpp           |   4 +-
 fred2/weaponeditordlg.cpp        |   2 +-
 35 files changed, 380 insertions(+), 378 deletions(-)

------------------------------------------------------------------------
commit 1e40f71
Author: z64555 <Thu Aug 18 01:00:10 2016 -0500>
Commit: z64555 <Thu Aug 18 01:00:10 2016 -0500>

    * Renames VM_EXTERNAL_CAMERA_LOCKED into VM_CAMERA_LOCKED and uses it for both freelook and external views. (Replaces slew_active) * Adds VM_CENTERING to replace view_centering * view_modify() now takes care of centering the view * Reorganized view-related controls and logic to be cleaner
 code/globalincs/systemvars.h     |   3 +-
 code/io/keycontrol.cpp           |   6 +-
 code/parse/lua.cpp               |   2 +-
 code/playerman/playercontrol.cpp | 201 +++++++++++++++++++--------------------
 4 files changed, 106 insertions(+), 106 deletions(-)

------------------------------------------------------------------------
commit c2b6417
Author: z64555 <Tue Aug 16 16:24:42 2016 -0500>
Commit: z64555 <Tue Aug 16 16:24:42 2016 -0500>

    [Cleanup] Changes player_set_padlock_state() to take parameters instead of directly operating on globals.
 code/playerman/playercontrol.cpp | 35 ++++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 17 deletions(-)


[den5]

What this error mean? I got it when run The Babylon Project. And <Freespace 2 Open stopped working> when clicking Debug.

Code: [Select]

Assert: "static_cast<size_t>(idx) < values.size()"
File: globalincs/flagset.h
Line: 83
Invalid value passed to flagset::set(), get a stacktrace, a coder, an old priest and a young priest.

ntdll.dll! ZwWaitForSingleObject + 21 bytes
kernel32.dll! WaitForSingleObjectEx + 67 bytes
kernel32.dll! WaitForSingleObject + 18 bytes
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>

[ This info is in the clipboard so you can paste it somewhere now ]


Use Debug to break into Debugger, Exit will close the application.

ntdll.dll! ZwWaitForSingleObject + 21 bytes
kernel32.dll! WaitForSingleObjectEx + 67 bytes
kernel32.dll! WaitForSingleObject + 18 bytes
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>
fs2_open_3_7_5_20160823_eb086da_SSE2-FASTDBG.exe! <no symbol>


[attachment deleted by admin]

[The E]

It means that something somewhere has tried to set a flag value that doesn't exist. This is bad for various reasons, and should never actually happen. If you can, compile your own debug build and try to get the exe to crash in the same way; If that's not possible, I need you to tell me what exactly you were doing when this warning happened. I will then try to reproduce and fix this.

EDIT: The issue has been found. The fix will be in one of the next nightlies.

[den5]

It means that something somewhere has tried to set a flag value that doesn't exist. This is bad for various reasons, and should never actually happen. If you can, compile your own debug build and try to get the exe to crash in the same way; If that's not possible, I need you to tell me what exactly you were doing when this warning happened. I will then try to reproduce and fix this.

Just copied ai / bp2-aip from BPComplete and added $glide decay requires thrust: YES in bp2-aip.

18 August 2016 - Revision e9cc460 is last working build without warning.

19 August 2016 - Revision 127976c got these errors

Code: [Select]

Error: weapons.tbl(line 40):
Error: Reading string list.  Found [$].  Expecting '('.

File: parselo.cpp
Line: 290

ntdll.dll! ZwWaitForSingleObject + 21 bytes
kernel32.dll! WaitForSingleObjectEx + 67 bytes
kernel32.dll! WaitForSingleObject + 18 bytes
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
kernel32.dll! BaseThreadInitThunk + 18 bytes
ntdll.dll! RtlInitializeExceptionChain + 99 bytes
ntdll.dll! RtlInitializeExceptionChain + 54 bytes

Error: counter-wep.tbm(line 36):
Error: Reading string list.  Found [$].  Expecting '('.

File: parselo.cpp
Line: 290

ntdll.dll! ZwWaitForSingleObject + 21 bytes
kernel32.dll! WaitForSingleObjectEx + 67 bytes
kernel32.dll! WaitForSingleObject + 18 bytes
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
fs2_open_3_7_5_20160819_127976c_SSE2.exe! <no symbol>
kernel32.dll! BaseThreadInitThunk + 18 bytes
ntdll.dll! RtlInitializeExceptionChain + 99 bytes
ntdll.dll! RtlInitializeExceptionChain + 54 bytes
All the next builds and this one - current error.

EDIT: The issue has been found. The fix will be in one of the next nightlies.

Thank you The E. What issue was there?

[The E]

In order to parse flag lists, the engine relies on a master list of flag names that pair their human-readable names with their in-engine representations. In the case of the weapon flags, that list used a value defined to be invalid (yes, this makes sense) as the in-engine representation for a few flags that are, for one reason or another, obsolete. The problem was that I forgot to account for this in the function that does the actual flag parsing, which ended up causing the issue seen here.

As for this new issue: please post the weapons.tbl you're using.

[den5]

19 August 2016 - Revision 127976c got these errors

Forgot to say: the game runs but no any weapons there.

As for this new issue: please post the weapons.tbl you're using.

attached below

[attachment deleted by admin]

[fightermedic]

It means that something somewhere has tried to set a flag value that doesn't exist. This is bad for various reasons, and should never actually happen. If you can, compile your own debug build and try to get the exe to crash in the same way; If that's not possible, I need you to tell me what exactly you were doing when this warning happened. I will then try to reproduce and fix this.

EDIT: The issue has been found. The fix will be in one of the next nightlies.

Thank you, that bug was driving me insane yesterday, i thought it had something todo with my mod, as in the mediavps it did not occure