Author Topic: Set-ship-position  (Read 3186 times)

0 Members and 1 Guest are viewing this topic.

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Actually, with so many campaigns in development (and released) that use set-ship-position, the best solution would be to change your sexp to set-waypoint-position and just drop the wings entirely.  People can set individual ships if they really want to.

 

Offline WMCoolmon

  • Purveyor of space crack
  • 213
:wtf:

Just because it can do the same thing doesn't mean it HAS to. If having redundant SEXPs is so bad, we could always make set-ship-position deprecated by removing it from the list of SEXPs that can be added in FRED.
-C

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Quote
Originally posted by WMCoolmon
Just because it can do the same thing doesn't mean it HAS to.
Huh?  It sounds like you're arguing my point here.  Just because set-waypoint-position can, with little modification move ships as well as waypoints, doesn't mean we should incorporate set-ship-position's behavior.
Quote
If having redundant SEXPs is so bad, we could always make set-ship-position deprecated by removing it from the list of SEXPs that can be added in FRED.
Except the SCP doesn't deprecate anything.  We're fully backwards compatible.  So removing it from the sexp list doesn't make any sense, because it will still always be supported.

 

Offline WMCoolmon

  • Purveyor of space crack
  • 213
I already wrote the code, added the features, everything. I could split it up into separate functions - set-waypoint-position, set-team-position, set-wing-position - but it'll just needlessly clutter up the SEXP list with extra SEXPs. I suppose I could also pop up an error message telling people to use set-ship-position instead of just doing it with set-object-position, but - why? :wtf: We've already got get-object-position SEXPs, it makes sense to have set-object-position SEXPs as well.

Quote
Except the SCP doesn't deprecate anything. We're fully backwards compatible. So removing it from the sexp list doesn't make any sense, because it will still always be supported.


But apparently it's absolutely unacceptable to have two fully supported SEXPs that can do the same thing. set-object-position does the same thing as set-ship-position and more, so it doesn't make much sense to keep set-ship-position in favor of set-object-position. I'd say just leave them both in - set-ship-position is slightly faster for setting ships and already used.
-C

  

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Set-wing-position isn't needed.  Set-team-position makes no sense.

Bah.  I'll check it out this weekend.