[Zarax]

Hello, FRED 2.3.3 failed to open, with the following error log:

Error: Error parsing 'ships.tbl'
Error code = 1.

File:E:\freespace2_public\code\Ship\Ship.cpp
Line: 1721

Call stack:
------------------------------------------------------------------
    Fred2-3.2.exe 00633d02()
    Fred2-3.2.exe 00633d7c()
    Fred2-3.2.exe 0061f69b()
    Fred2-3.2.exe 0061e67f()
    Fred2-3.2.exe 0061e888()
    USER32.dll 77d13a5f()
    USER32.dll 77d19797()
    USER32.dll 77d15874()
    USER32.dll 77d19a87()
    ntdll.dll 77f4108f()
    USER32.dll 77d1add9()
    USER32.dll 77d11505()
    Fred2-3.2.exe 0061ed95()
    Fred2-3.2.exe 00633ccf()
    Fred2-3.2.exe 00633edf()
------------------------------------------------------------------

[Inquisitor]

Bugzilla

[DTP]

Originally posted by Zarax
Hello, FRED 2.3.3 failed to open, with the following error log:

Error: Error parsing 'ships.tbl'
Error code = 1.

File:E:\freespace2_public\code\Ship\Ship.cpp
Line: 1721

Call stack:
------------------------------------------------------------------
    Fred2-3.2.exe 00633d02()
    Fred2-3.2.exe 00633d7c()
    Fred2-3.2.exe 0061f69b()
    Fred2-3.2.exe 0061e67f()
    Fred2-3.2.exe 0061e888()
    USER32.dll 77d13a5f()
    USER32.dll 77d19797()
    USER32.dll 77d15874()
    USER32.dll 77d19a87()
    ntdll.dll 77f4108f()
    USER32.dll 77d1add9()
    USER32.dll 77d11505()
    Fred2-3.2.exe 0061ed95()
    Fred2-3.2.exe 00633ccf()
    Fred2-3.2.exe 00633edf()
------------------------------------------------------------------

char get_engine_wash_index(char *engine_wash_name)
{
   int i;

   for (i=0; i      if ( 0 == stricmp(engine_wash_name, Engine_wash_info.name) ) { // THIS IS LINE
         return (char)i;
      }
   }

   // not found, so return -1
   return -1;
}

you messed up the enginewash type info or something on your custom model.

well, check your model before commit any bugzilla report.
and to everybody else, it is good commen pratice to rule out ERROR #15 (sits 15 inches from the screen) .

[Inquisitor]

Go DTP

Probably worth logging in bugzilla, then making notes to that effect, thus beginning to turn bugzilla into a practical knowledge base

[Zarax]

Well, there weren't new models...
I found the probelm in the end...
FRED 2.3.2 has a table size limit set around 395k...
I thought it was a size problem and i was right...
So, either DTP code and FRED 2.3.2 are different or there is some kind of bug around...
Hope it helps,
                        Zarax

[Inquisitor]

We had been tweaking the actual limit to check into some hardware compatibility, so the limit might be a little lower.

I am wondering if the actual table size limit needs to be run time configureable, to accomodate mod makers who want to have the higher sys reqs.

DTP, what say you? It's your code (originally)?

[Zarax]

Well, from what i can tell from my test it remembers me more of the original  code than DTP's...
I mean, after i trimmed my tables in order to make them work with FRED 2.3.2, i found that also FRED 2 standard opens them!
Table size is 393kb.
Another fix needed (this is higher in priority) is the send message - sexp, wich stopped working...
Hope that it helps,
                                Zarax

[EdrickV]

You might want to double check Ship.h, the original has multiple defines for the max number of ships. For non-debug builds, FRED2 has a lower limit then FS2 does. For debug builds both have higher limits then normal. Not sure if there may be a similar thing for the file/buffer sizes as I'm not entirely sure what defines them.

[DTP]

its just funny that you can start fred2 at all, since if my tbl is to big, then fred will not start at all, i dont even get an error. maybe because of, if you ran the debug build.

i recall penguin rolled back the table size limit when he mis-indentified that table size limit causing an error on mission load.

This was the "playing with the same pilot in different mods" error.

I will take a look at the various defines for both fs2 and fred2 regarding table size limit and check up on the max ships and max sub objects limit also. whats the use of having more kbs of file when you "only" get 70 new ships to add.

I will write a some text about what the new limits are, and maybe we can put it, in the new readme file.

edit

oh i forgot, the limits would be the original limits, if penguin rolled all changes regarding this back.

edit2

seems Penguin never ever rolled back anything.

tbl limit 1 mb
max ships 400 with an average of 7 subobjects
or meaning max 21 ships with 100 subsystems each

[Zarax]

Well, when i mean FRED2 i mean the original  one, the one that you get when you install the game...

[DTP]

yeah, well, i can see on where the game crashes for you, that it has something to do with the engine wash info in your tbl file, and recall that is in the start of your tbl file.

so im still wondering if you edited any part of this in your tbl file.

since if it has something to do with a limit of 395 kbs, then well fred2 shouldnt open at all, let alone give you an error, it would just refuse to open.

I tested this long ago with a file that had a size of 700 kbs.
and had nearly 200 ships.

All these new ships where copies of collossus and the sathana, and where just given a diffenrent name. and they all had engine wash info bound to them.

So im sure the KB limit has nothing to do with it.

but i will re-asure myself when i get the time to create another nearly 1 mb size tbl file. And test if fred2_open works with it.

for now, try and download an alternative Fred2 from http://www.c4-group.dk/?C=0&case=index just enter download section and download max freespace2.zip

if you dont have it already.

And try and see if the fred2 found in that zip opens your tbl file.
that version supports 1 mb tbl files and 400 ships. and i have tested this as i have flown mission with 32 sathanas, 400 modified ships + 1 demon. ofcourse the frames pr second where low as 5-7. but that stress testing profed that it works. while I had close to 200 ships in my 700 kb tbl file.

if that version fails to open, or gives you the same error, then you file is messy.

Sorry. But send it to me, and i will check what could be wrong.

[email protected]

That the original FRED2 opens your file is well,

That it does, buggers the hell out of me, i simply can' t beleive it, untill i see it.


and since the game crashes where it should never ever since you should never ever modify engine wash section in your tbl file.

well, i simply dont understand it, unless you have modified the engine wash section of the tbl file. maybe accidently.

so please send it to me so i can re-assure what is wrong with the code, or maybe the tbl file.

[DTP]

ok i just tested a 405 kb file with lots of sathanas and collosus ships, that where just given a different name. behold the following picture.

To big to show here, put it is found here

http://home19.inet.tele.dk/dtp/images/manyships.jpg


so i stay by my opinion.

it is still an Error #15.

sorry.

the fact the FRED2 standard, the one from volitions runs with the tbl file is puzzeling.

have you tried it on Fred2_open 3.2 after you edited at all?.

[Zarax]

Well, i did the following things in this order...

1) edited my ship.tbl, final size 465k
2)FRED 2.3.2 failed to open
3)Tried with FRED 2 DTP, with positive results
4)Done some trim & test until FRED 2.3.2 was able to open, final size: 395k
5)just for testing purposes i tried to opn it with  FRED 2, and it worked...

As a modder i switched on FRED 2.3.2/FS2 Open, so i'm very interested in source code changes...
Hope it helps,
                       Zarax

[DTP]

Originally posted by Zarax
Well, i did the following things in this order...

1) edited my ship.tbl, final size 465k
2)FRED 2.3.2 failed to open
3)Tried with FRED 2 DTP, with positive results
4)Done some trim & test until FRED 2.3.2 was able to open, final size: 395k
5)just for testing purposes i tried to opn it with  FRED 2, and it worked...

As a modder i switched on FRED 2.3.2/FS2 Open, so i'm very interested in source code changes...
Hope it helps,
                       Zarax

could you send me the tbl ?.

Dont worry, i will reveal nothing i read, since we/i will then try to solve this via Email.

I got a recent build of FRED2_open, i just want to nail what ever bug it might be.

email is [email protected]

[EdrickV]

FYI, the original FRED2 exe thread, (which is now buried) states that it doesn't include the new ship limits because they were having trouble with them. Whether that means the ships.tbl or MAX_SHIPS I don't know. (And we could really use a FRED2_Open download link on the Warpcore page, otherwise you have to hunt that buried thread down to find out where to download the thing.)

[EdrickV]

DTP's FRED2 will open up to at least a 953k ships.tbl. The 3.2 FRED2_open exe won't even open a 400k ships.tbl file. It crashes with a GPF. The engine wash thing is probably not caused by the table size limit.

Edit: And, to make sure parsing problems were not involved, I altered the table's size by adding a lot of ;'s to the end that should be ignored by the program itself. That means it is only the file size limit that is causing the problems.

[DTP]

Hmmm, weird, I looked for penguin’s rollback comment, but faulted to find it.

Indeed weird.

So that’s the problem.

The build released did not have those upped limits, because of the mistaken presumption that these where causing the problem that really was caused by playing with the same pilot in multiple mods.

...
we really should generate some new binaries and release them.

Inquisitor, what do you say, should we, and who, and where to put them.

I could upload some new builds of the CVS copy, that i will be building if Inquisitor approves.

I´ll try to contact him about this, maybe even put together a description of the varios commandline flags. +what-ever i can think off.

[Inquisitor]

If you read the "New build" thread, I'd like to have a new exe ASAP

Go ahead and committ the new table stuff, maybe get bobboau's fighter beam code updated, I have a list somewhere I wanted to discuss with the group.

If you have an EXE you are happy with, pop it up somehwere, we can all take a quick look at then call it 3.3

[DTP]

the thing is about the table stuff, i only commited it once, penguin said he rolled it back, but seems he never did, and yet FRED2 3.2 dont support the uppded limits

that is what is so dam weird.

deleting my copy of the CVS, in order to get the all changes that i might have missed since yesterday, just to be sure

but not my work copy

downloading, and doing new builds.

I will inform of a link when i´m done building.

[Inquisitor]

lemme look at the CVS for fred 2, maybe I missed something.