Ok, first, you may try chamfering the edges where different angles join, especially the hard edges around the bottom. Nothing in the real world comes to a perfect 90 degree corner. It's subtile, but the improvement on lighting is well worth it. The groove around the bottom is probably too deep, but that's purely artistic. Also, in complete opposition to TopAce, you need far more polys around the cylinder. At least 30 segments, probably more, but enough to get rid of the visible segmentation. Finally, I see you haven't finished the bottom yet. You might want to get on that

Looks good though, I like the general composition and the lighting setup. Basic perhaps, but not bad.