Author Topic: Ballistic primaries flag  (Read 1373 times)

0 Members and 1 Guest are viewing this topic.

Offline Wanderer

  • Wiki Warrior
  • 211
  • Mostly harmless
Ballistic primaries flag
So... About this flag in ships.tbl... Is it needed or is it not? Depending on the build you use it either triggers warnings if its missing or if it is present.

Quite a while ago it was IIRC mandatory to get fighter to use the ballistic primaries. Then using it started triggering warnings and flag was generally removed from ships.tbl. Now the game again triggers warnings if the flag is missing? Could quite well be related into this issue reported by MP-Ryan. So any ideas?
Do not meddle in the affairs of coders for they are soggy and hard to light

 

Offline Quiet

  • Shhh.
  • 24
Re: Ballistic primaries flag
Is this the warning you're getting Wanderer? "Pbank capacity specified for non-ballistic-primary-enabled ship" and then assert failures if you try and fire?

After I switched from a CVS build to the latest trunk from SVN I got that (I'm working around it by tweaking some of the btrl tables since it's not urgent I need them). I'm still learning the code but is it possible this is happening?

In ship/parse_ship at line 3800 the ballistic flag is set (sip->flags |= SIF_BALLISTIC_PRIMARIES;)

Then at 3897 it's reset if a $Flag entry is found (sip->flags = SIF_DEFAULT_VALUE;)

 

Offline taylor

  • Super SCP/Linux Guru
  • Moderator
  • 212
    • http://www.icculus.org/~taylor
Re: Ballistic primaries flag
After I switched from a CVS build to the latest trunk from SVN I got that (I'm working around it by tweaking some of the btrl tables since it's not urgent I need them). I'm still learning the code but is it possible this is happening?

In ship/parse_ship at line 3800 the ballistic flag is set (sip->flags |= SIF_BALLISTIC_PRIMARIES;)

Then at 3897 it's reset if a $Flag entry is found (sip->flags = SIF_DEFAULT_VALUE;)
I noticed the same thing a few minutes ago and already committed a fix. :)

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Re: Ballistic primaries flag
Oops. :nervous: