[Colonol Dekker]

This is one of those dragons den moments. One of those things i wished i'd thought of. Any chance of using the briefing icons system too?

[Goober5000]

I don't think it's very hard to call the source code used by loadout screen for command briefing.

Really?  This is excellent news.  I'm so glad someone took the time to examine the code and evaluate the difficulty level for us.  Do you think you could send us a feature patch while you're at it?

[blowfish]

I got it to stop screwing up the interface, thanks to gr_reset_clip (you forgot to tell me about this WMC ), but now it just doesn't do anything.  I've just been testing with fighter01.pof, but it displays nothing out of the ordinary...

[karajorma]

I don't think it's very hard to call the source code used by loadout screen for command briefing.

Really?  This is excellent news.  I'm so glad someone took the time to examine the code and evaluate the difficulty level for us.  Do you think you could send us a feature patch while you're at it?

Well he did say he'd check the source code so he might not actually be doing the talking out his hat that most people do when they say something is easy. I wouldn't bet money on it though.

[WMCoolmon]

Here's a quick working patch; I recommend you apply dmr_fix.diff to your codebase. This puts gr_reset_clip into draw_rotating_model, where it should be, and fixes a minor problem where the function assumed it was rendering a missile if you didn't specify a closeup pos. It'll change three files but you'll have to revise your missioncmdbrief.cpp to take into account the gr_reset_clip change (ie just get rid of the one you added).

The other patch is for a quick working test I made.

[attachment deleted by admin]

[blowfish]

I never learned how to incorporate a diff into your local source how do you do it?

[WMCoolmon]

TortoiseSVN includes a patch application utility. If you have it installed, you right-click on the file, go to the TortoiseSVN menu, and then go to 'apply patch' and select your missionui directory.

[blowfish]

What if I am not using windows and 'svn patch' is not available?

[WMCoolmon]

Then I don't know. Or at least I can't give you any definite solutions. There is a patch utility under Linux, that might be available under Mac OS X, that might be able to use the diff files.

If nothing else, you can always crack open the diff files and do the changes manually; there's not more than ~20-30 lines changed. "+" indicates a line that was added, "-" indicates a line that was removed. Neither +/- indicates that the line was not changed, and can be used to locate where the change was made. The line numbers above each 'chunk' indicate where that change occurred, although since you are changing the relative position of things in the file, the line number may not be accurate, and I generally avoid using it when patching manually. (It might come in handy for duplicate code sections, though)

[blowfish]

I know how to read a diff file!

[blowfish]

Thanks for the code, WMC.  This works now.  I should be able to do the rest pretty easily

[WMCoolmon]

[blowfish]

What? I'm SCP now?  Anyway:

Command, those coordinates you gave us are bogus.  Its x, y, width, height, not corner, other corner   Spent a lot of tim trying to figure that out...

[Goober5000]

You have access to the internal forum, by recommendation. Check it out.

[blowfish]

Well, after wrestling with Console, making many stupid mistakes, and discovering that I had the wrong coordinates, I finally got this finished.  I've tested it a bunch, but whoever commits it should probably look it over and you might want to test it a little yourself.  Also, someone will have to add this to FRED, as I can't.  So basically how it works is in the mission, after the ani filename, it looks for "+Ship Class:", "+Weapon Class:", or "+Model Name:" (only one of the three).  Defining a ship or weapon sets some special behavior.  For ships, it uses the table-defined closeup position and zoom values.  For weapons, it uses the tech model if available, if not it uses the regular POF file (unless the weapon is a primary - flak behaves weirdly), assumed to be a missile so that the center is set up correctly.  I removed the 1.7 multiplier from the closeup zoom, because I thought it looked better that way in a longer rectangle.  I guess that's pretty much it.  So here's the diff.

And BTW, we should really be able to attach diff files.

EDIT: Darn!  Forgot to add code to deal with when a ship class doesn't exist.  Appears to be a fatal error.

EDIT2: Fixed and reuploaded.  Forgot to mention that using a ship causes a slight, but noticeable pause when initializing a briefing stage.

EDIT3: And forgot to thank WMCoolmon for showing me how to get this to work in the first place!  How could I forget that?

[attachment deleted by admin]

[chief1983]

Actually I think it's better to use an archive than a plain text file attachment anyway.  I just prefer having those types of things archived, even if it's not compressed.