[SirKnightly]

Here is the nightly for Windows on 27 Jul 2009 - Revision 5492

fso-WIN-20090727_r5492.7z
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r5492 | portej05 | 2009-07-27 11:06:24 -0500 (Mon, 27 Jul 2009) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/ai.cpp
   M /trunk/fs2_open/code/ai/ai_profiles.cpp
   M /trunk/fs2_open/code/ai/aicode.cpp
   M /trunk/fs2_open/code/anim/animplay.cpp
   M /trunk/fs2_open/code/bmpman/bmpman.cpp
   M /trunk/fs2_open/code/camera/camera.cpp
   M /trunk/fs2_open/code/cfile/cfile.cpp
   M /trunk/fs2_open/code/cfile/cfilelist.cpp
   M /trunk/fs2_open/code/cfile/cfilesystem.cpp
   M /trunk/fs2_open/code/cmdline/cmdline.cpp
   M /trunk/fs2_open/code/controlconfig/controlsconfig.cpp
   M /trunk/fs2_open/code/controlconfig/controlsconfigcommon.cpp
   M /trunk/fs2_open/code/cutscene/cutscenes.cpp
   M /trunk/fs2_open/code/cutscene/movie.cpp
   M /trunk/fs2_open/code/cutscene/mvelib.cpp
   M /trunk/fs2_open/code/cutscene/oggplayer.cpp
   M /trunk/fs2_open/code/ddsutils/ddsutils.cpp
   M /trunk/fs2_open/code/debugconsole/console.cpp
   M /trunk/fs2_open/code/debugconsole/dbugfile.cpp
   M /trunk/fs2_open/code/demo/demo.cpp
   M /trunk/fs2_open/code/fireball/fireballs.cpp
   M /trunk/fs2_open/code/fred2/addvariabledlg.cpp
   M /trunk/fs2_open/code/fred2/bgbitmapdlg.cpp
   M /trunk/fs2_open/code/fred2/briefingeditordlg.cpp
   M /trunk/fs2_open/code/fred2/campaigneditordlg.cpp
   M /trunk/fs2_open/code/fred2/campaigntreeview.cpp
   M /trunk/fs2_open/code/fred2/campaigntreewnd.cpp
   M /trunk/fs2_open/code/fred2/cmdbrief.cpp
   M /trunk/fs2_open/code/fred2/customwingnames.cpp
   M /trunk/fs2_open/code/fred2/debriefingeditordlg.cpp
   M /trunk/fs2_open/code/fred2/eventeditor.cpp
   M /trunk/fs2_open/code/fred2/fred.cpp
   M /trunk/fs2_open/code/fred2/freddoc.cpp
   M /trunk/fs2_open/code/fred2/fredrender.cpp
   M /trunk/fs2_open/code/fred2/mainfrm.cpp
   M /trunk/fs2_open/code/fred2/management.cpp
   M /trunk/fs2_open/code/fred2/messageeditordlg.cpp
   M /trunk/fs2_open/code/fred2/missiongoalsdlg.cpp
   M /trunk/fs2_open/code/fred2/missionnotesdlg.cpp
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/fred2/modifyvariabledlg.cpp
   M /trunk/fs2_open/code/fred2/reinforcementeditordlg.cpp
   M /trunk/fs2_open/code/fred2/sexp_tree.cpp
   M /trunk/fs2_open/code/fred2/shipeditordlg.cpp
   M /trunk/fs2_open/code/fred2/shipgoalsdlg.cpp
   M /trunk/fs2_open/code/fred2/shiptexturesdlg.cpp
   M /trunk/fs2_open/code/fred2/voiceactingmanager.cpp
   M /trunk/fs2_open/code/fred2/waypointpathdlg.cpp
   M /trunk/fs2_open/code/fred2/wing.cpp
   M /trunk/fs2_open/code/fred2/wing_editor.cpp
   M /trunk/fs2_open/code/freespace2/freespace.cpp
   M /trunk/fs2_open/code/fs2netd/fs2netd_client.cpp
   M /trunk/fs2_open/code/gamehelp/gameplayhelp.cpp
   M /trunk/fs2_open/code/gamesnd/eventmusic.cpp
   M /trunk/fs2_open/code/globalincs/pstypes.h
   M /trunk/fs2_open/code/globalincs/systemvars.cpp
   M /trunk/fs2_open/code/globalincs/version.cpp
   M /trunk/fs2_open/code/globalincs/windebug.cpp
   M /trunk/fs2_open/code/graphics/2d.cpp
   M /trunk/fs2_open/code/graphics/gropengl.cpp
   M /trunk/fs2_open/code/graphics/gropengltexture.cpp
   M /trunk/fs2_open/code/hud/hud.cpp
   M /trunk/fs2_open/code/hud/hudbrackets.cpp
   M /trunk/fs2_open/code/hud/hudconfig.cpp
   M /trunk/fs2_open/code/hud/hudescort.cpp
   M /trunk/fs2_open/code/hud/hudmessage.cpp
   M /trunk/fs2_open/code/hud/hudparse.cpp
   M /trunk/fs2_open/code/hud/hudshield.cpp
   M /trunk/fs2_open/code/hud/hudsquadmsg.cpp
   M /trunk/fs2_open/code/hud/hudtarget.cpp
   M /trunk/fs2_open/code/hud/hudtargetbox.cpp
   M /trunk/fs2_open/code/inetfile/cftp.cpp
   M /trunk/fs2_open/code/inetfile/chttpget.cpp
   M /trunk/fs2_open/code/inetfile/inetgetfile.cpp
   M /trunk/fs2_open/code/io/keycontrol.cpp
   M /trunk/fs2_open/code/io/timer.cpp
   M /trunk/fs2_open/code/jpgutils/jpgutils.cpp
   M /trunk/fs2_open/code/lab/lab.cpp
   M /trunk/fs2_open/code/lab/wmcgui.cpp
   M /trunk/fs2_open/code/localization/localize.cpp
   M /trunk/fs2_open/code/menuui/barracks.cpp
   M /trunk/fs2_open/code/menuui/mainhallmenu.cpp
   M /trunk/fs2_open/code/menuui/optionsmenu.cpp
   M /trunk/fs2_open/code/menuui/optionsmenumulti.cpp
   M /trunk/fs2_open/code/menuui/playermenu.cpp
   M /trunk/fs2_open/code/menuui/readyroom.cpp
   M /trunk/fs2_open/code/menuui/snazzyui.cpp
   M /trunk/fs2_open/code/menuui/techmenu.cpp
   M /trunk/fs2_open/code/mission/missionbriefcommon.cpp
   M /trunk/fs2_open/code/mission/missioncampaign.cpp
   M /trunk/fs2_open/code/mission/missionhotkey.cpp
   M /trunk/fs2_open/code/mission/missionload.cpp
   M /trunk/fs2_open/code/mission/missionlog.cpp
   M /trunk/fs2_open/code/mission/missionmessage.cpp
   M /trunk/fs2_open/code/mission/missionparse.cpp
   M /trunk/fs2_open/code/mission/missiontraining.cpp
   M /trunk/fs2_open/code/missionui/chatbox.cpp
   M /trunk/fs2_open/code/missionui/fictionviewer.cpp
   M /trunk/fs2_open/code/missionui/missionbrief.cpp
   M /trunk/fs2_open/code/missionui/missioncmdbrief.cpp
   M /trunk/fs2_open/code/missionui/missiondebrief.cpp
   M /trunk/fs2_open/code/missionui/missionscreencommon.cpp
   M /trunk/fs2_open/code/missionui/missionshipchoice.cpp
   M /trunk/fs2_open/code/missionui/missionweaponchoice.cpp
   M /trunk/fs2_open/code/missionui/redalert.cpp
   M /trunk/fs2_open/code/model/modelread.cpp
   M /trunk/fs2_open/code/nebula/neb.cpp
   M /trunk/fs2_open/code/network/chat_api.cpp
   M /trunk/fs2_open/code/network/multi.cpp
   M /trunk/fs2_open/code/network/multi_campaign.cpp
   M /trunk/fs2_open/code/network/multi_data.cpp
   M /trunk/fs2_open/code/network/multi_dogfight.cpp
   M /trunk/fs2_open/code/network/multi_endgame.cpp
   M /trunk/fs2_open/code/network/multi_ingame.cpp
   M /trunk/fs2_open/code/network/multi_log.cpp
   M /trunk/fs2_open/code/network/multi_observer.cpp
   M /trunk/fs2_open/code/network/multi_options.cpp
   M /trunk/fs2_open/code/network/multi_pause.cpp
   M /trunk/fs2_open/code/network/multi_pinfo.cpp
   M /trunk/fs2_open/code/network/multi_pmsg.cpp
   M /trunk/fs2_open/code/network/multi_pxo.cpp
   M /trunk/fs2_open/code/network/multi_rate.cpp
   M /trunk/fs2_open/code/network/multi_respawn.cpp
   M /trunk/fs2_open/code/network/multi_update.cpp
   M /trunk/fs2_open/code/network/multi_xfer.cpp
   M /trunk/fs2_open/code/network/multimsgs.cpp
   M /trunk/fs2_open/code/network/multiteamselect.cpp
   M /trunk/fs2_open/code/network/multiui.cpp
   M /trunk/fs2_open/code/network/multiutil.cpp
   M /trunk/fs2_open/code/network/psnet.cpp
   M /trunk/fs2_open/code/network/psnet2.cpp
   M /trunk/fs2_open/code/network/stand_gui.cpp
   M /trunk/fs2_open/code/object/parseobjectdock.cpp
   M /trunk/fs2_open/code/osapi/osapi.cpp
   M /trunk/fs2_open/code/osapi/osapi_unix.cpp
   M /trunk/fs2_open/code/osapi/osregistry.cpp
   M /trunk/fs2_open/code/osapi/osregistry_unix.cpp
   M /trunk/fs2_open/code/osapi/outwnd.cpp
   M /trunk/fs2_open/code/palman/palman.cpp
   M /trunk/fs2_open/code/parse/lua.cpp
   M /trunk/fs2_open/code/parse/scripting.cpp
   M /trunk/fs2_open/code/parse/sexp.cpp
   M /trunk/fs2_open/code/pcxutils/pcxutils.cpp
   M /trunk/fs2_open/code/playerman/managepilot.cpp
   M /trunk/fs2_open/code/playerman/playercontrol.cpp
   M /trunk/fs2_open/code/popup/popup.cpp
   M /trunk/fs2_open/code/radar/radarsetup.cpp
   M /trunk/fs2_open/code/ship/ship.cpp
   M /trunk/fs2_open/code/ship/shiphit.cpp
   M /trunk/fs2_open/code/sound/audiostr-openal.cpp
   M /trunk/fs2_open/code/sound/ds.cpp
   M /trunk/fs2_open/code/sound/fsspeech.cpp
   M /trunk/fs2_open/code/sound/sound.cpp
   M /trunk/fs2_open/code/species_defs/species_defs.cpp
   M /trunk/fs2_open/code/starfield/starfield.cpp
   M /trunk/fs2_open/code/stats/medals.cpp
   M /trunk/fs2_open/code/stats/scoring.cpp
   M /trunk/fs2_open/code/stats/stats.cpp
   M /trunk/fs2_open/code/tgautils/tgautils.cpp
   M /trunk/fs2_open/code/ui/gadget.cpp
   M /trunk/fs2_open/code/weapon/emp.cpp
   M /trunk/fs2_open/code/weapon/shockwave.cpp
   M /trunk/fs2_open/code/weapon/weapons.cpp
   M /trunk/fs2_open/lua/luaconf.h

safe_strings - from Antipodes build #1
------------------------------------------------------------------------



[Black Wolf]

Dunno if this is the build or my mods, but I got this:

Assert: 0
File: safe_strings.cpp
Line: 61
ERANGE: String error @ e:\storage\fso\fs2_open_0\code\cfile\cfilesystem.cpp (570). Please Report

ntdll.dll! KiFastSystemCallRet
kernel32.dll! WaitForSingleObjectEx + 67 bytes
kernel32.dll! WaitForSingleObject + 18 bytes
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
fs2_open_3_6_11d-20090727_r5492.exe! <no symbol>
kernel32.dll! BaseThreadInitThunk + 18 bytes
ntdll.dll! RtlProcessFlsData + 211 bytes
ntdll.dll! RtlProcessFlsData + 166 bytes

Running Windows 7 with these command lines:

C:\Program Files\FreeSpace2\fs2_open_3_6_11d-20090727_r5492.exe -mod TI,TI,mediavps -spec -glow -env -mipmap -missile_lighting -normal -3dshockwave -targetinfo -ship_choice_3d -weapon_choice_3d -3dwarp -warp_flash -fps -window  -ambient_factor 25 -spec_exp 10.0 -spec_tube 0.4 -spec_point 0.6 -spec_static 0.8

and it could very well be my mod directory, which is a bit of a shermozzle at the best of times, but it said please report, so I did

[EDIT]Yesterday's works.

[Echelon9]

Assert: 0
File: safe_strings.cpp
Line: 61
ERANGE: String error @ e:\storage\fso\fs2_open_0\code\cfile\cfilesystem.cpp (570). Please Report
...
[EDIT]Yesterday's works.

This is exactly the sort of error message portej05's safe_strings is meant to reveal. Thanks for the report. We've known that some of the unsafe C string operations were leading to memory corruption that resulted in numerous subtle, hard to diagnose crashes. Safe_strings gives us better insight when this occurs, and provides information necessary to fix it.

This particular instance is caused by code in cfilesystem.cpp that searches through the base and mod's root path, looking for valid files the FSO engine will then parse. I'd say there's a table or similar file with a very long (longer than CF_MAX_FILENAME_LENGTH, 32) name and extension.

I'll let portje05 comment further, as he knows these assurance changes best.

[chief1983]

The filename can't be more than 31 characters because of the null terminator, and that includes the extension, typically 4 chars, so you're left with 27 characters.  ED had a 29 character filename the other day that was causing the same problem for them.  Check your debug log, it will tell you where it was scanning, roughly, when it crashed.  It'll likely only tell you your mod folder, but that's at least a way to know it's the mod data causing it.  Diaspora had a couple of long file names too.  One thing in particular to look for is music files apparently, that or textures because the -normal adds 7 characters and limits you to a 20 char base name.  I just wish these errors were a bit more helpful.

[portej05]

In this particular case, the following is occurring:

Code: [Select]

strcpy_s( file->name_ext, find.name );
Where file->name_ext is a buffer 32 characters long (including space for the NULL) and find.name is 260 characters long.
This has probably been going undetected for a while - we'll need to make a decision about how to handle this, as more people are hitting this now.