[QuantumDelta]

I believe there is a flag to allow that behavior but it definitely should be off in retail and the MediaVPs.  The commit of that flag and what it controls might be a good place to start the search for the change in behavior though.  

There is? If so, it's not in ai profiles... at least not on the wiki...

I think he means;
 $smart secondary weapon selection:
FS2 Open, 3.6.10 or earlier:

    * If set, enables the new secondary weapon selection method (including proper use of bomber+ missiles)


Edit;
Also, confirmed, bomber improved bomb dropping behaviour isn't present in 3.6.10 Final Kara
They still launch what seems like more bombs than they used to, but no where near what is in current SCP (*side note, I'm not SURE they launch more bombs than they used to in Final, it just 'looked' like it, but) there is a definite and significant difference that I imagine anyone would be able to observe playing Apocalypse and watching the scene I posted pics from above right at the start of the mission, between final and .5615, for example.

[Sushi]

I believe there is a flag to allow that behavior but it definitely should be off in retail and the MediaVPs.  The commit of that flag and what it controls might be a good place to start the search for the change in behavior though.  

There is? If so, it's not in ai profiles... at least not on the wiki...

I think he means;
 $smart secondary weapon selection:

Ah. Well, after digging through the code a bit, I'm pretty sure that $smart secondary weapon selection doesn't make the AI change secondary banks more quickly. At least, not directly...still investigating.

Edit;
Also, confirmed, bomber improved bomb dropping behaviour isn't present in 3.6.10 Final Kara
They still launch what seems like more bombs than they used to, but no where near what is in current SCP (*side note, I'm not SURE they launch more bombs than they used to in Final, it just 'looked' like it, but) there is a definite and significant difference that I imagine anyone would be able to observe playing Apocalypse and watching the scene I posted pics from above right at the start of the mission, between final and .5615, for example.

Hmm. What happens in, say, 5542?
EDIT: Link to build:
http://www.mediafire.com/?sharekey=767261bd3368c539b64026cfc0611236e04e75f6e8ebb871

[karajorma]

I was actually asking about the bomb radius thing more than the bomb dropping thing.

[QuantumDelta]

Actually that seems to be different too (harder to tell then with the bomber drop million bombs thing tho ), bomb radius seems to be a fair bit bigger on pre-5548 builds (couldn't find a windows build which was 5545, but 5541 and 5548 have what FEELs to be quite a big difference).
Enhanced Bomber behaviour wasn't in 5548 either btw.

[Sushi]

Actually that seems to be different too (harder to tell then with the bomber drop million bombs thing tho ), bomb radius seems to be a fair bit bigger on pre-5548 builds (couldn't find a windows build which was 5545, but 5541 and 5548 have what FEELs to be quite a big difference).
Enhanced Bomber behaviour wasn't in 5548 either btw.

Aw blast. 5549 was big AI commit of mine, so it's looking like that's the culprit (for some things anyway). Time to figure out how I screwed up bombers...and if I screwed up anything else in the process...

[QuantumDelta]

Aw blast. 5549 was big AI commit of mine, so it's looking like that's the culprit (for some things anyway). Time to figure out how I screwed up bombers...and if I screwed up anything else in the process...

Well I haven't tested 5549 yet, I'll do that now - I had to pop out earlier.

Edit;
Heh, that's not even subtle, the bomber AI change is in 5550

[Sushi]

Aw blast. 5549 was big AI commit of mine, so it's looking like that's the culprit (for some things anyway). Time to figure out how I screwed up bombers...and if I screwed up anything else in the process...

Well I haven't tested 5549 yet, I'll do that now - I had to pop out earlier.

Edit;
Heh, that's not even subtle, the bomber AI change is in 5550

So, the change is in 5550 but NOT 5549? Or did you only test 5550?

Another thing to watch out for is that between 5543 and 5549 (inclusive) there was another bug that had to do with afterburner (it was fixed in 5550). Make sure you aren't confounding with that.

[QuantumDelta]

Only tested 5550, 5548, and 5541 (*closest available from the nightly forum )

[Sushi]

Here's a 5549 for you.

http://www.mediafire.com/?sharekey=767261bd3368c539b64026cfc0611236e04e75f6e8ebb871

[QuantumDelta]

Okay;
5549, bombers launch 4 bombs on their way into the Ptah-Nu at the start of Apocalypse.
5550, bombers launch 12 bombs on their way into the Ptah-Nu at the start of Apocalypse.
It's _definitely_ 5550

[chief1983]

Maybe that 'unreachable' code wasn't so unreachable after all?

[Sushi]

Okay;
5549, bombers launch 4 bombs on their way into the Ptah-Nu at the start of Apocalypse.
5550, bombers launch 12 bombs on their way into the Ptah-Nu at the start of Apocalypse.
It's _definitely_ 5550

And I assume you still get the 12-bomb thing in the latest nightlies...

5550 is a fairly small commit by Kara, with the following changes:
Change #1: Fix afterburner bug.
Change #2: Remove unreachable code.
Change #3: Added some missing typecasts dealing with ships taking off or landing at a hangar bay.

None of those things seem like they should have any impact at all on bombs. Very strange. To be honest, I haven't a clue what's going on there.

Maybe there's some other subtle difference between nightly builds the builds I've been giving you? Here's a 5550 that I built, if you want to check:
http://www.mediafire.com/?sharekey=767261bd3368c539b64026cfc0611236e04e75f6e8ebb871

Maybe that 'unreachable' code wasn't so unreachable after all?

Maybe, but I don't see how. It's of the form

Code: [Select]

if (Stuff)
{
 do stuff
 return
}
else
{
 do other stuff
 return
}

unreachable code here

Seems pretty unreachable to me...

EDIT: Besides, that code has to do with primary weapons, not secondaries.

[Tomo]

I'm doing a couple of 'before-and-after' builds here to confirm as well.

As Sushi said (while I was typing), the changes don't look like they should have any effect on bombs, even if the 'unreachable' wasn't actually so.

(EDIT)
I don't see the multi-bomb bug in a debug build of 5550.

I'll have a look to see what the next change to AI code was.

Aha - build 5551 has several very big changes in HUGE_SECONDARY stuff, intended as a bugfix to Mantis 1987.

I'll do a build to check, but that looks to be a likely culprit.

[QuantumDelta]

http://www.hard-light.net/forums/index.php?topic=65395.0
This was my 5550 build x_X

[Tomo]

...and I'm not seeing it in 5551 either.

I may have utterly screwed up the build process somewhere... going to jump to a build I *know* had it.

(EDIT) Yes, I did screw up the build process. Didn't force a rebuild of /code so the post above is complete tosh. (Still not too familiar with MSVC++)

I'll try that again, this time with Stupid turned off...

[QuantumDelta]

/soothes Tomo

[Tomo]

Thanks QuantumDelta, that makes me feel a lot better.

Yes, this does appear in 5550.

I'm seeing Seraphim fire double bombs in 5550, and single bombs in 5549.

And now I'm going to bed before I make an even bigger fool of myself.

[karajorma]

The only possible explanation is that fixing the afterburner thing is somehow having a knock on effect. Try changing that back to the way it was and see if the problem fixes itself (or I'll try later today).

[Tomo]

I've done some partial merges between 5549 and 5550, but I'm not seeing conclusive differences.

With just the Afterburner edit, Seraphim 'occasionally' fired double warheads in a couple of runthoughs.

With just the other edits, they also did...

Going to do a bit more - and is there somewhere I can upload these builds to?
I tried to attach them but they are ever so slightly too large.

[Thaeris]

Quite off-topic, but I can't help but think this when I read through this:

The Shivans...

     We can rebuild them...

          Better... Stronger... Faster...

...

Hey, wait... no, we don't!!!