Author Topic: Reverse Afterburner support patch  (Read 6061 times)

0 Members and 1 Guest are viewing this topic.

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
Here is an updated to Trunk version: 5845-RevAB.patch

This resolves some spacing changes in ship.cpp and ship.h.

Works as advertised, no new warnings in MSVC 2008.

EDIT:

Although, being able to use the existing "+Aburn Max Vel: 0.0, 0.0, 150.0" and adding in the speed to replace the 0.0, 0.0 (like we do for Glide n' Slide) and making it +Aburn For accel: and +Aburn Slide accel: would probably be handier for folks to use, but may or may not be more complicated.

Sushi and/or Backslash is probably the expert in this area though.
« Last Edit: January 27, 2010, 10:46:05 pm by Zacam »
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline Sushi

  • Art Critic
  • 211
Re: Reverse Afterburner support patch

Although, being able to use the existing "+Aburn Max Vel: 0.0, 0.0, 150.0" and adding in the speed to replace the 0.0, 0.0 (like we do for Glide n' Slide) and making it +Aburn For accel: and +Aburn Slide accel: would probably be handier for folks to use, but may or may not be more complicated.

I'm afraid I don't understand what you are trying to get at. Care to explain further?

 

Offline Nuke

  • Ka-Boom!
  • 212
  • Mutants Worship Me
Re: Reverse Afterburner support patch
he wants lateral and vertical afterburners too
I can no longer sit back and allow communist infiltration, communist indoctrination, communist subversion, and the international communist conspiracy to sap and impurify all of our precious bodily fluids.

Nuke's Scripting SVN

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
Yup. Sorry, I was verging on some serious need of sleep at that point last night.

Basically, Siled/Glide is able to use the X and Y in $Max Velocity. I'm suggesting that, rather than adding in "+Aburn Max Reverse Vel" that we use the X and Y values in "+Aburn Max Vel:" instead.  The +Aburn accel functions could probably be entirely optional for Rev and Side.

(or better, added to "afterburner_forward_accel" to have it handle X Y and Z instead, but we might run into compatibility problems (potentially) as retail never stored X or Y there.)
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline Nuke

  • Ka-Boom!
  • 212
  • Mutants Worship Me
Re: Reverse Afterburner support patch
the way i would do it is id give every degree of freedom its own max speed, acceleration, and deceleration values. technically speaking reverse acceleration would be the same thing as forward deceleration, since the means of slowing down is the same as the means for going in reverse. for slide (a term ive always considered a misnomer, but will use for the sake of sanity) the acceleration would be positive rate and your deceleration would be your negative rate, so for lateral slide, the acceleration would be how fast you accelerate to the left and deceleration being your acceleration to right. this is what my physics mod does, except uses forces instead of accelerations.

of course it seems like this would cause some compatability issues with retail tables, so just stick a slide accel in the afterburner section. +Aburn For accel: is a float and not a vector, and changing it to a vector will piss off every modder on hlp, unless of course if you detect this at parse time and if only one number is found, stick it into the z component, assume x and y are 0 and use the data as a vector, otherwise pars as a vector. the x and y max velocities should go where they go now. of course this is inconsistent with the way normal slide acceleration is handled, so then we go back to just adding +Aburn Slide Accel:
« Last Edit: January 28, 2010, 08:11:13 pm by Nuke »
I can no longer sit back and allow communist infiltration, communist indoctrination, communist subversion, and the international communist conspiracy to sap and impurify all of our precious bodily fluids.

Nuke's Scripting SVN

 

Offline Sushi

  • Art Critic
  • 211
Re: Reverse Afterburner support patch
Well, although I agree that it might make sense to someday extend this to allow sidethrust afterburners as well, that is a bit more complicated and not needed by anyone at the moment. The reverse afterburners, on the other hand, are needed.

The good news is that the current additions to the table structure don't preclude the eventual addition of sidethrust afterburners. I do think that it's worth committing what we have now before worrying about extending it further, though.

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
...srsly?

If it'll be a nice addition and a worthy feature, why not make the commit complete and get it all in now, rather than gettin half in now, potentially forgetting about the rest until sometime later and then maybe getting it done then?

I'll take a look then at adding in the expanded functionality.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: Reverse Afterburner support patch
Sometimes it's not worth it to do 90% of the work to get 10% more feature.  People have priorities.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
And one of those priorities should be making features fully complete, rather than just doing the minimum necessary to implement the idea.

Now, seeing as how the feature works exactly as desired, I'm not laying this on the maker of the .patch file, but I do think a little for-thought and work on polishing it now and then putting it in would be a far better direction than just deciding "good enough" and saving it as is until later.

That is usually the root cause for why the majority of our current code looks the way it does, IMO.
« Last Edit: January 29, 2010, 03:02:07 pm by Zacam »
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: Reverse Afterburner support patch
Our current problems are due to badly coded features, not features that weren't taking every possibility into account.  If it's not more work than it was to get this far, that's one thing, but if it's an order of magnitude harder to implement side thrust it doesn't make much sense right now.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Sushi

  • Art Critic
  • 211
Re: Reverse Afterburner support patch
My point was that the patch, as it is, should definitely go in. If you want to "complete" the feature further by making it support sidethrust as well, go right ahead, but there's no need to delay what we have so far in order to accomplish that.

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
Patch (as is) committed on revision 5858.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline Sushi

  • Art Critic
  • 211
Re: Reverse Afterburner support patch
Great!

SparK, please make sure you update the freespace wiki to reflect the new table entries.
(http://hard-light.net/wiki/index.php/Ships.tbl)

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
Actually, I went ahead and did that too.

Feedback on the formatting would be nice, since $Afterburners did not sub-tree it's section very well, I altered that.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline Spoon

  • 212
  • ヾ(´︶`♡)ノ
Re: Reverse Afterburner support patch
The formatting on the wiki looks good to me  :yes:
Looking forward trying backwards afterburner (will give it a try the moment the nightly 5858 for windows is out)
Urutorahappī!!

[02:42] <@Axem> spoon somethings wrong
[02:42] <@Axem> critically wrong
[02:42] <@Axem> im happy with these missions now
[02:44] <@Axem> well
[02:44] <@Axem> with 2 of them

 

Offline Spoon

  • 212
  • ヾ(´︶`♡)ノ
Re: Reverse Afterburner support patch
Okay i've just tested it out. There is one issue with it however, if you are not flying at full forward speed the normal afterburner will not work properly. Instead of accelerating you to max normal speed and then exceeding that amount, it now only adds a small percentage ontop the speed you are currently flying.
So for example if the ship you are flying has a top speed of 140 and you set your speed to 30 and then trigger afterburners you'll only accelerate to say, 43. While consuming fuel etc.

The backwards afterburner works fine as long as you keep Z+tab both pressed.
Urutorahappī!!

[02:42] <@Axem> spoon somethings wrong
[02:42] <@Axem> critically wrong
[02:42] <@Axem> im happy with these missions now
[02:44] <@Axem> well
[02:44] <@Axem> with 2 of them

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
Well ****. Confirmed.

And if you are at absolute zero, you don't go anywhere at all.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: Reverse Afterburner support patch
Seriously guys?  Abort Retry Fail :P
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
It only affects ships where a TBM is used to specify a reverse AB speed.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Steam
    • Twitter
    • ModDB Feature
Re: Reverse Afterburner support patch
5863 Fixes this issue. Now even with a TBM defining a  ship to have Reverse AB, standard forward AB behaviour is retained.

(Zero or non-full Forward Velocity now accelerates to Max Afterburner, unless and until Reverse Thrust is also used)
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys