[SirKnightly]

Here is the nightly for OS X on 29 Aug 2011 - Revision 7566

Group: Inferno
fso-OSX-Inferno-20110829_r7566.tgz
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r7539 | Goober5000 | 2011-08-26 22:57:16 -0500 (Fri, 26 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/campaigneditordlg.cpp
   M /trunk/fs2_open/code/fred2/campaigneditordlg.h
   M /trunk/fs2_open/code/fred2/campaigntreeview.cpp
   M /trunk/fs2_open/code/fred2/campaigntreeview.h
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/menuui/readyroom.cpp
   M /trunk/fs2_open/code/mission/missioncampaign.cpp
   M /trunk/fs2_open/code/mission/missioncampaign.h
   M /trunk/fs2_open/code/missionui/missiondebrief.cpp
   M /trunk/fs2_open/code/missionui/missionloopbrief.cpp
   M /trunk/fs2_open/code/network/multiui.cpp

add infrastructure and parsing support for mission forks (vs. mission loops)
mission fork interface art and selection logic still needs to be written
------------------------------------------------------------------------
r7540 | Goober5000 | 2011-08-26 23:39:18 -0500 (Fri, 26 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

enhance end-mission to possibly dump player to main hall
------------------------------------------------------------------------
r7541 | Goober5000 | 2011-08-27 00:08:39 -0500 (Sat, 27 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/ai/ai.h
   M /trunk/fs2_open/code/fred2/management.cpp
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/fred2/shipflagsdlg.cpp
   M /trunk/fs2_open/code/fred2/shipspecialhitpoints.cpp
   M /trunk/fs2_open/code/mission/missionparse.cpp
   M /trunk/fs2_open/code/mission/missionparse.h
   M /trunk/fs2_open/code/parse/sexp.cpp
   M /trunk/fs2_open/code/ship/ship.cpp
   M /trunk/fs2_open/code/ship/ship.h

return special exp values to ints, per discussion with Zacam awhile ago
while we're at it, change kamikaze damage to int since it's treated as such
------------------------------------------------------------------------
r7542 | Goober5000 | 2011-08-27 00:27:24 -0500 (Sat, 27 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/globalincs/vmallocator.h

add linked lists, woot
------------------------------------------------------------------------
r7544 | Goober5000 | 2011-08-27 22:31:46 -0500 (Sat, 27 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/parselo.cpp
   M /trunk/fs2_open/code/parse/parselo.h

add dynamic vector stuffing
------------------------------------------------------------------------
r7545 | Echelon9 | 2011-08-28 01:50:02 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/graphics/2d.h

PVS-Studio fix: V802 On 32-bit platform, structure size can be reduced from 28 to 24 bytes by rearranging the fields according to their sizes in decreasing order.
------------------------------------------------------------------------
r7546 | Echelon9 | 2011-08-28 01:55:00 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/controlconfig/controlsconfig.h

PVS-Studio fix: V802 On 32-bit platform, structure size can be reduced from 24 to 20 bytes by rearranging the fields according to their sizes in decreasing order.
------------------------------------------------------------------------
r7547 | Echelon9 | 2011-08-28 02:00:38 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/object/objectdock.h

PVS-Studio fix: V802 On 32-bit platform, structure size can be reduced from 40 to 32 bytes by rearranging the fields according to their sizes in decreasing order.
------------------------------------------------------------------------
r7548 | Echelon9 | 2011-08-28 02:03:57 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/bmpman/bm_internal.h

PVS-Studio fix: V802 On 32-bit platform, structure size can be reduced from 52 to 48 bytes by rearranging the fields according to their sizes in decreasing order.
------------------------------------------------------------------------
r7549 | Echelon9 | 2011-08-28 02:08:40 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multi_data.cpp

PVS-Studio fix: V802 On 32-bit platform, structure size can be reduced from 50 to 48 bytes by rearranging the fields according to their sizes in decreasing order.
------------------------------------------------------------------------
r7550 | Echelon9 | 2011-08-28 02:16:42 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/model.h

PVS-Studio fix: V802 On 32-bit platform, structure size can be reduced from 80 to 76 bytes by rearranging the fields according to their sizes in decreasing order.
------------------------------------------------------------------------
r7551 | Echelon9 | 2011-08-28 02:27:53 -0500 (Sun, 28 Aug 2011) | 5 lines
Changed paths:
   M /trunk/fs2_open/code/network/chat_api.cpp

PVS-Studio fix: V501 There are identical sub-expressions '(stricmp (szCmd, "372") == 0)' to the left and to the right of the '||' operator.

and

V501 There are identical sub-expressions '(stricmp (szCmd, "375") == 0)' to the left and to the right of the '||' operator.
------------------------------------------------------------------------
r7552 | Echelon9 | 2011-08-28 02:39:56 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/controlconfig/controlsconfig.h

Revert r7546 -- will need more work.
------------------------------------------------------------------------
r7553 | Echelon9 | 2011-08-28 03:31:25 -0500 (Sun, 28 Aug 2011) | 7 lines
Changed paths:
   M /trunk/fs2_open/code/autopilot/autopilot.cpp
   M /trunk/fs2_open/code/camera/camera.cpp
   M /trunk/fs2_open/code/cfile/cfilesystem.cpp
   M /trunk/fs2_open/code/cutscene/cutscenes.cpp
   M /trunk/fs2_open/code/debris/debris.cpp
   M /trunk/fs2_open/code/fireball/fireballs.cpp
   M /trunk/fs2_open/code/fs2netd/fs2netd_client.cpp
   M /trunk/fs2_open/code/fs2netd/tcp_client.cpp
   M /trunk/fs2_open/code/gamesnd/gamesnd.cpp
   M /trunk/fs2_open/code/object/collideshipship.cpp
   M /trunk/fs2_open/code/parse/scripting.cpp
   M /trunk/fs2_open/code/parse/sexp.cpp
   M /trunk/fs2_open/code/sound/sound.cpp

PVS-Studio fix: V803 Decreased performance. In case 'tvs' is iterator it's more effective to use prefix form of increment. Replace iterator++ with ++iterator.

For further discussion see, http://www.viva64.com/en/b/0093/

The scenarios where it will improve performance are under Debug builds. This improvement will however allow quicker use of other profiling tools that need to run on Debug builds.

Note. Code with size_t does not see the performance improvement comparison to iterators due to absence of array overrun check.
------------------------------------------------------------------------
r7554 | Echelon9 | 2011-08-28 03:54:10 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/lua.cpp

Documentation: Clean up lua.cpp
------------------------------------------------------------------------
r7555 | Echelon9 | 2011-08-28 04:30:07 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp

PVS-Studio fix: V519 The 'path_index' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 12782, 12809 (aicode.cpp)
------------------------------------------------------------------------
r7556 | Echelon9 | 2011-08-28 04:31:21 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/graphics/gropenglpostprocessing.cpp

PVS-Studio fix: V519 The 'list_size' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 597, 604 (gropenglpostprocessing.cpp)
------------------------------------------------------------------------
r7557 | Echelon9 | 2011-08-28 04:32:55 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multi_obj.cpp

PVS-Studio fix: V519 The 'player_index' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1389, 1392 (multi_obj.cpp)
------------------------------------------------------------------------
r7558 | Echelon9 | 2011-08-28 04:34:09 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multi_pxo.cpp

PVS-Studio fix: V519 The 'num_users' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 2296, 2297 (multi_pxo.cpp)
------------------------------------------------------------------------
r7559 | Echelon9 | 2011-08-28 04:36:18 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multi_obj.cpp

Documentation: Code cleanup in multi_obj.cpp
------------------------------------------------------------------------
r7560 | Echelon9 | 2011-08-28 04:41:54 -0500 (Sun, 28 Aug 2011) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/io/joy.cpp

PVS-Studio fix: V555 The expression '(now - bi->last_down_check) > 0' will work as 'now != bi->last_down_check'.

Due to unsigned int type wrapping the former code would have always returned true.
------------------------------------------------------------------------
r7561 | Echelon9 | 2011-08-28 04:49:02 -0500 (Sun, 28 Aug 2011) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

PVS-Studio fix: V516 Consider inspecting an odd expression. Non-null function pointer is compared to null: 'jumpnode_get_by_name == 0' (sexp.cpp).

Ironic that check_sexp_syntax() appeared to have a mistake in it's check functions.
------------------------------------------------------------------------
r7562 | Echelon9 | 2011-08-28 07:48:20 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/graphics/2d.h

Reverting 7545: Due to some odd errors coming through as Asserts in cfile.cpp
------------------------------------------------------------------------
r7563 | Echelon9 | 2011-08-28 10:10:07 -0500 (Sun, 28 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

Documentation: Code cleanup of sexp.cpp
------------------------------------------------------------------------
r7565 | Echelon9 | 2011-08-29 08:19:58 -0500 (Mon, 29 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/menuui/barracks.cpp
   M /trunk/fs2_open/code/mission/missionhotkey.cpp

PVS-Studio fix (Courtesy of niffiwan): V523 The 'then' statement is equivalent to the 'else' statement (barracks.cpp and missionhotkey.cpp).
------------------------------------------------------------------------
r7566 | Echelon9 | 2011-08-29 11:08:03 -0500 (Mon, 29 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/hud/hud.cpp

PVS-Studio fix: V515 The 'delete' operator is applied to non-pointer (hud.cpp).
------------------------------------------------------------------------