[SirKnightly]

Here is the nightly for OS X on 30 Aug 2011 - Revision 7584

Group: Inferno
fso-OSX-Inferno-20110830_r7584.tgz
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r7567 | karajorma | 2011-08-29 19:18:32 -0500 (Mon, 29 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multi_sexp.cpp
   M /trunk/fs2_open/code/parse/sexp.cpp

Documentation for the Multiplayer SEXP system.
------------------------------------------------------------------------
r7568 | Goober5000 | 2011-08-29 22:35:42 -0500 (Mon, 29 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/ai.cpp
   M /trunk/fs2_open/code/ai/ai.h
   M /trunk/fs2_open/code/ai/aicode.cpp
   M /trunk/fs2_open/code/ai/aigoals.cpp
   M /trunk/fs2_open/code/autopilot/autopilot.cpp
   M /trunk/fs2_open/code/autopilot/autopilot.h
   M /trunk/fs2_open/code/fred2/briefingeditordlg.cpp
   M /trunk/fs2_open/code/fred2/campaigneditordlg.cpp
   M /trunk/fs2_open/code/fred2/createwingdlg.cpp
   M /trunk/fs2_open/code/fred2/dumpstats.cpp
   M /trunk/fs2_open/code/fred2/fredrender.cpp
   M /trunk/fs2_open/code/fred2/fredview.cpp
   M /trunk/fs2_open/code/fred2/management.cpp
   M /trunk/fs2_open/code/fred2/management.h
   M /trunk/fs2_open/code/fred2/missionnotesdlg.cpp
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/fred2/missionsave.h
   M /trunk/fs2_open/code/fred2/orienteditor.cpp
   M /trunk/fs2_open/code/fred2/sexp_tree.cpp
   M /trunk/fs2_open/code/fred2/ship_select.cpp
   M /trunk/fs2_open/code/fred2/ship_select.h
   M /trunk/fs2_open/code/fred2/shipeditordlg.cpp
   M /trunk/fs2_open/code/fred2/shipgoalsdlg.cpp
   M /trunk/fs2_open/code/fred2/waypointpathdlg.cpp
   M /trunk/fs2_open/code/fred2/wing_editor.cpp
   M /trunk/fs2_open/code/freespace2/freespace.cpp
   M /trunk/fs2_open/code/hud/hud.cpp
   M /trunk/fs2_open/code/mission/missionparse.cpp
   M /trunk/fs2_open/code/network/multimsgs.cpp
   M /trunk/fs2_open/code/object/waypoint.cpp
   M /trunk/fs2_open/code/object/waypoint.h
   M /trunk/fs2_open/code/parse/lua.cpp
   M /trunk/fs2_open/code/parse/sexp.cpp
   M /trunk/fs2_open/code/parse/sexp.h
   M /trunk/fs2_open/code/ship/ship.cpp
   M /trunk/fs2_open/code/ship/shipfx.cpp

waypoints and waypoint paths now have dynamic limits
------------------------------------------------------------------------
r7569 | karajorma | 2011-08-29 23:12:55 -0500 (Mon, 29 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/playerman/playercontrol.cpp

Gliding remains on when the player restarts a mission.
------------------------------------------------------------------------
r7570 | Goober5000 | 2011-08-30 02:27:32 -0500 (Tue, 30 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp
   M /trunk/fs2_open/code/object/waypoint.cpp
   M /trunk/fs2_open/code/object/waypoint.h
   M /trunk/fs2_open/code/ship/ship.cpp

having null iterators is apparently a no-no according to the C++ standard, so use a globally defined invalid iterator instead
------------------------------------------------------------------------
r7571 | Goober5000 | 2011-08-30 02:29:57 -0500 (Tue, 30 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/fred2/sexp_tree.cpp
   M /trunk/fs2_open/code/network/multimsgs.cpp
   M /trunk/fs2_open/code/network/multimsgs.h
   M /trunk/fs2_open/code/parse/sexp.cpp
   M /trunk/fs2_open/code/parse/sexp.h
   M /trunk/fs2_open/code/weapon/beam.cpp
   M /trunk/fs2_open/code/weapon/beam.h

add fire-beam-at-coordinates, which is as awesome as it sounds
------------------------------------------------------------------------
r7572 | karajorma | 2011-08-30 06:50:23 -0500 (Tue, 30 Aug 2011) | 4 lines
Changed paths:
   M /trunk/fs2_open/code/network/multi_sexp.cpp

PVS-Studio fix: V512 A call of the 'memset' function will lead to underflow of the buffer 'type'.

Never really would matter but it's a waste of memory declaring an int buffer and then only using 1/4 of it

------------------------------------------------------------------------
r7573 | Echelon9 | 2011-08-30 08:06:28 -0500 (Tue, 30 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missiontraining.cpp

PVS-Studio fix (courtesy of niffiwan): V523 The 'then' statement is equivalent to the 'else' statement (missiontraining.cpp).
------------------------------------------------------------------------
r7574 | Echelon9 | 2011-08-30 08:12:51 -0500 (Tue, 30 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/menuui/techmenu.cpp

PVS-Studio (courtesy of niffiwan): V523 The 'then' statement is equivalent to the 'else' statement (techmenu.cpp).
------------------------------------------------------------------------
r7575 | The_E | 2011-08-30 08:21:28 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/voiceactingmanager.cpp

PVS Studio fix: duplicated "!strlen(filename)" check

------------------------------------------------------------------------
r7576 | The_E | 2011-08-30 08:38:33 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/lab/wmcgui.cpp

PVS Studio fix: "delete operator applied to non-pointer"

------------------------------------------------------------------------
r7577 | The_E | 2011-08-30 08:40:36 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/sexp_tree.cpp

PVS Studio fix: V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 279, 287.

------------------------------------------------------------------------
r7578 | The_E | 2011-08-30 08:46:00 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/bmpman/bmpman.cpp

PVS Studio fix: V535 The variable 'i' is being used for this loop and for the outer loop.

------------------------------------------------------------------------
r7579 | The_E | 2011-08-30 08:48:56 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/missionsave.cpp

PVS Studio fix: V547 Expression is always true. Unsigned type value is always >= 0.

------------------------------------------------------------------------
r7580 | The_E | 2011-08-30 08:55:36 -0500 (Tue, 30 Aug 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/model/modelanim.cpp

PVS Studio fix: V570 The 'end_angle.a1d [axis]' variable is assigned to itself.

------------------------------------------------------------------------
r7581 | Echelon9 | 2011-08-30 09:06:03 -0500 (Tue, 30 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp

PVS-Studio fix: V803 Decreased performance. In case 'aip->wp_index' is iterator it's more effective to use prefix form of decrement. Replace iterator-- with --iterator.
------------------------------------------------------------------------
r7582 | Echelon9 | 2011-08-30 09:32:10 -0500 (Tue, 30 Aug 2011) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/ship/shipfx.cpp

PVS-Studio fix: V523 The 'then' statement is equivalent to the 'else' statement (shipfx.cpp).

Also take opportunity to clean up the BSG warp effect code. That duplice if() else() had been included since the original WMC commit in r5261.
------------------------------------------------------------------------
r7583 | Echelon9 | 2011-08-30 10:17:28 -0500 (Tue, 30 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missioncampaign.cpp

PVS-Studio fix: V805 Decreased performance. It is inefficient to identify an empty string by using 'strlen(str) == 0' construct. A more efficient way is to check: str[0] == '\0' (missioncampaign.cpp).
------------------------------------------------------------------------
r7584 | Echelon9 | 2011-08-30 10:39:29 -0500 (Tue, 30 Aug 2011) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/menuui/barracks.cpp
   M /trunk/fs2_open/code/network/multi_pinfo.cpp
   M /trunk/fs2_open/code/network/multi_pxo.cpp
   M /trunk/fs2_open/code/network/multiui.cpp
   M /trunk/fs2_open/code/network/stand_gui.cpp
   M /trunk/fs2_open/code/stats/scoring.h
   M /trunk/fs2_open/code/stats/stats.cpp

PVS-Studio fix: V576 Incorrect format. Consider checking the [third] actual argument of the 'sprintf' function. The SIGNED integer type argument is expected.

Fixes a number of this class of issue with sprintf formats.
------------------------------------------------------------------------