[SirKnightly]

Here is the nightly for Windows on 03 Nov 2012 - Revision 9315

Group: Inferno
fso-WIN-Inferno-20121103_r9315.7z
MD5Sum

Group: Inferno_SSE
fso-WIN-Inferno_SSE-20121103_r9315.7z
MD5Sum

Group: Inferno_SSE2
fso-WIN-Inferno_SSE2-20121103_r9315.7z
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r9302 | karajorma | 2012-11-03 01:08:22 -0500 (Sat, 03 Nov 2012) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

Object numbers are not guaranteed to the same on the client. Sent the net_sig instead.
------------------------------------------------------------------------
r9303 | karajorma | 2012-11-03 03:25:27 -0500 (Sat, 03 Nov 2012) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missiontraining.cpp
   M /trunk/fs2_open/code/network/multi.cpp
   M /trunk/fs2_open/code/network/multi.h

Clear out some cruft from the multiplayer code. Make sure Macros are being used.
------------------------------------------------------------------------
r9304 | karajorma | 2012-11-03 04:01:17 -0500 (Sat, 03 Nov 2012) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multi.h

Turns out you do need some of those after all. No idea why grep didn't find them.
------------------------------------------------------------------------
r9305 | The_E | 2012-11-03 04:23:23 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/anim/animplay.cpp
   M /trunk/fs2_open/code/camera/camera.cpp
   M /trunk/fs2_open/code/cutscene/mveplayer.cpp
   M /trunk/fs2_open/code/graphics/2d.cpp

PVS Studio fix: Add checks against NULL pointer dereferences

------------------------------------------------------------------------
r9306 | The_E | 2012-11-03 04:24:25 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/graphics/gropenglstate.cpp

PVS Studio suggestion: Use ++it for iterators

------------------------------------------------------------------------
r9307 | The_E | 2012-11-03 04:25:48 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/graphics/gropengltnl.cpp

PVS Studio suggestion: Create a reference instead of repeated vector access

------------------------------------------------------------------------
r9308 | The_E | 2012-11-03 04:28:49 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/hud/hud.cpp

PVS Studio fix: String play_callsign is not used anywhere

------------------------------------------------------------------------
r9309 | The_E | 2012-11-03 04:31:54 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/hud/hudparse.cpp

PVS Studio suggestion: Create a reference to avoid multiple vector access operations

------------------------------------------------------------------------
r9310 | The_E | 2012-11-03 04:33:54 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/hud/hudsquadmsg.cpp

PVS Studio fix: "!none_valid" is always true

------------------------------------------------------------------------
r9311 | The_E | 2012-11-03 04:35:46 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/jpgutils/jpgutils.cpp

PVS Studio fix: Really confusing code

------------------------------------------------------------------------
r9312 | The_E | 2012-11-03 04:36:44 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/model/modelinterp.cpp

PVS Studio fix: Pointer shipp is not checked against NULL

------------------------------------------------------------------------
r9313 | The_E | 2012-11-03 04:37:29 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/network/multi_obj.cpp

PVS Studio fix: Pointer not checked against NULL

------------------------------------------------------------------------
r9314 | The_E | 2012-11-03 04:38:34 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/starfield/starfield.cpp
   M /trunk/fs2_open/code/weapon/muzzleflash.cpp

PVS Studio suggestion: Create a reference to avoid repeated vector access

------------------------------------------------------------------------
r9315 | The_E | 2012-11-03 04:39:11 -0500 (Sat, 03 Nov 2012) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/network/multi_pxo.cpp

PVS Studio fix: string last_portion is not used anywhere

------------------------------------------------------------------------



[MatthTheGeek]

http://scp.indiegames.us/mantis/view.php?id=2724

Also, .15 is not available for Mantis reports.

[chief1983]

Is now.  Updated your ticket with that version number.

[diegocmr]

any chance to see Mantis #2713 implemented on future nightly builds?

[karajorma]

http://scp.indiegames.us/mantis/view.php?id=2724

Also, .15 is not available for Mantis reports.

Well the issue is probably not the revision that Axem found unfortunately. That's just an assert if the data is NULL. The question is "Why is the data NULL"?


EDIT : My bad, I suspect that commit is actually the reason. Still, it's kinda sloppy to knowingly pass a null pointer to a function and hope it can deal with it.

My suggestion is not to remove the Int3() but instead to move it after the

Code: [Select]

if ( !(Interp_flags & MR_SHOW_THRUSTERS) ) {
return;
}

I suspect that in the case of ship selection that part of the code that was causing the function to return before the null pointer was actually used. If it's not, we really need to know.