[SirKnightly]

Here is the nightly for Windows on 16 Nov 2013 - Revision 10092

Group: NO-SSE
fso-WIN-NO-SSE-20131116_r10092.7z
MD5Sum

Group: Standard
fso-WIN-Standard-20131116_r10092.7z
MD5Sum

Group: SSE
fso-WIN-SSE-20131116_r10092.7z
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r10074 | Goober5000 | 2013-11-15 20:45:12 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/object/objectdock.h
   M /trunk/fs2_open/code/object/parseobjectdock.h

change dock_function_info to a class
------------------------------------------------------------------------
r10075 | Goober5000 | 2013-11-15 20:48:50 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/object/parseobjectdock.h

change p_dock_function_info to a class as well
------------------------------------------------------------------------
r10076 | Goober5000 | 2013-11-15 20:58:29 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/osapi/outwnd.cpp

ugh, neither the constructor nor the memsets are actually needed here
------------------------------------------------------------------------
r10077 | Goober5000 | 2013-11-15 21:20:39 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

now that we have queued_animation_init, we can rewrite this properly
------------------------------------------------------------------------
r10078 | Goober5000 | 2013-11-15 21:22:05 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp
   M /trunk/fs2_open/code/ship/ship.cpp

these memsets aren't needed
------------------------------------------------------------------------
r10079 | Goober5000 | 2013-11-15 22:37:27 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

memset initialized the wrong level of pointer :-/
------------------------------------------------------------------------
r10080 | Goober5000 | 2013-11-15 22:39:03 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp
   M /trunk/fs2_open/code/ship/ship.h

make man_thruster a POD struct, and initialize maneuvering thrusters in ship_info initialization
------------------------------------------------------------------------
r10081 | Goober5000 | 2013-11-15 22:39:38 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.h

this exited_ship constructor is redundant and interferes with the POD-ness of the struct
------------------------------------------------------------------------
r10082 | Goober5000 | 2013-11-15 23:51:59 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.h
   M /trunk/fs2_open/code/weapon/weapon.h
   M /trunk/fs2_open/code/weapon/weapons.cpp

remove non-working and non-supported $substitute feature for weapons (Mantis #2951)
------------------------------------------------------------------------
r10083 | Goober5000 | 2013-11-15 23:59:27 -0600 (Fri, 15 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/weapon/weapons.cpp

"new" shouldn't really ever fail
------------------------------------------------------------------------
r10084 | niffiwan | 2013-11-16 00:09:04 -0600 (Sat, 16 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/hud/hudshield.cpp

Remove a magic number
------------------------------------------------------------------------
r10085 | niffiwan | 2013-11-16 01:40:26 -0600 (Sat, 16 Nov 2013) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/network/multimsgs.cpp

Coverity 1129273: Negative array index read

weapon_create can return -1
------------------------------------------------------------------------
r10086 | niffiwan | 2013-11-16 01:42:52 -0600 (Sat, 16 Nov 2013) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/network/multimsgs.cpp

Coverity 1129272: Negative array index read

weapon_create can return -1
------------------------------------------------------------------------
r10087 | niffiwan | 2013-11-16 02:57:00 -0600 (Sat, 16 Nov 2013) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/ai/aiturret.cpp

Coverity 1129270: Negative array index read

weapon_create can return -1
------------------------------------------------------------------------
r10088 | niffiwan | 2013-11-16 03:01:01 -0600 (Sat, 16 Nov 2013) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/ai/aiturret.cpp

remove gcc warning: [-Wunused-but-set-variable]

(ret_val earmarked for future use)
------------------------------------------------------------------------
r10089 | niffiwan | 2013-11-16 03:30:50 -0600 (Sat, 16 Nov 2013) | 4 lines
Changed paths:
   M /trunk/fs2_open/code/hud/hudartillery.cpp

Coverity 1129270: Negative array index read

weapon_create can return -1
(& oops, r10087 was 1129271, not 1129270)
------------------------------------------------------------------------
r10090 | niffiwan | 2013-11-16 03:55:39 -0600 (Sat, 16 Nov 2013) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

Coverity 1129274: Negative array index read

weapon_create can return -1
------------------------------------------------------------------------
r10091 | niffiwan | 2013-11-16 04:46:50 -0600 (Sat, 16 Nov 2013) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/weapon/weapons.cpp

Coverity 1129269: Dereference after null check

add checks to deal with parent_objp == NULL
------------------------------------------------------------------------
r10092 | niffiwan | 2013-11-16 04:49:34 -0600 (Sat, 16 Nov 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/weapon/weapons.cpp

fix gcc warning: declaration of ‘shipp’ shadows a previous local [-Wshadow]
------------------------------------------------------------------------



[Macfie]

Ran into a problem with this build.  I was playing the updated Derelict Campaign and was in mission d4-m8.  I selected alt-T to turnoff targeting and the game froze and crashed to desk top.  I restarted and tried it again and it did it again.  I went to the BP build based off nightly 10060 did the same thing and it worked fine.

[Goober5000]

Hmm.  Is this reproducible on a mission with retail data?

[Macfie]

What exactly do you mean by "retail data"?

[The E]

Running FS2 with no mods.

[Macfie]

I'll check tonight when I get off work.

[Macfie]

I checked it with no mods and it exhibited the same behavior.

[Goober5000]

So, what, you target any ship, then press Alt-T and it crashes?  Because I've done that and it works fine.

Granted I'm playing on debug builds, so if it's a release-only problem, I wouldn't see it that way.

[Macfie]

It doesn't even have to be targeted on a ship, I did it in the final cutscene of derelict and it crashed.  I tried the 10111 build and it had the same problem.  I didn't try it in debug though.

Edit: tried it in debug and you're right it does not do it.

[Goober5000]

Can you open a Mantis ticket for this?

What about the trunk build based on nightly 10060?  The crash could be caused by a difference between the two builds.

[Macfie]

Mantis ticket 0002958.
I'll download and try the trunk Nightly (Windows): 14 Nov 2013 - Revision 10060 tonight after I get off work.