Author Topic: Lighting settings in game_settings.tbl  (Read 213 times)

0 Members and 1 Guest are viewing this topic.

Offline m!m

  • 210
Lighting settings in game_settings.tbl
I just submitted some changes which would allow a mod to specify the lighting settings in the mod table. Before that gets merged I would like to let everyone know that this pull request exists in case someone has something to say about the general idea of this feature.

 

Offline The E

  • He's Ebeneezer Goode
  • Global Moderator
  • 213
  • Nothing personal, just tech support.
    • Skype
    • Steam
    • Twitter
Re: Lighting settings in game_settings.tbl
One issue is definitely clear: Since we've treated those lighting settings as user input exclusively so far, user input should retain priority over game_settings definitions (this post is written quickly, off the cuff and without checking whether we parse cmdline options before or after game_settings)
**** every cause that ends in murder and children crying. ― Iain Banks
Join the fun at the HLP IRC channel. Get the latest spam and gossip as long as it's fresh!

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: Lighting settings in game_settings.tbl
Why should we not give a mod the ability to lock down the settings a bit?  Yes we gave users that ability so they could experiment and find things that worked, but for a mod like Windmills it is absolutely critical that it be played with very specific lighting settings, and if we could bundle those with the mod via a table, and prevent user override additionally, I can't see any reason why that wouldn't be preferred.  I just feel that if a mod wants to go to the extent of developing very specific lighting settings critical to the mood, etc, the user shouldn't just be able to easily override those because they're used to being able to do so.  I don't think anyone would be upset if a mod going forward prevented that, and if so they could take it up with the modder.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline The E

  • He's Ebeneezer Goode
  • Global Moderator
  • 213
  • Nothing personal, just tech support.
    • Skype
    • Steam
    • Twitter
Re: Lighting settings in game_settings.tbl
There is probably a middle ground there. Let mods define a min, max and default value and clamp the user preference to that if it exists.
**** every cause that ends in murder and children crying. ― Iain Banks
Join the fun at the HLP IRC channel. Get the latest spam and gossip as long as it's fresh!

 

Offline m!m

  • 210
Re: Lighting settings in game_settings.tbl
For the first question, yes the game_settings values override whatever the user specified.

I guess I could add a range feature. That shouldn't be hard to implement.

EDIT: I have implemented the requested range feature in the changes I linked to above.
« Last Edit: June 29, 2018, 05:44:15 pm by m!m »

 

Online AdmiralRalwood

  • 211
  • The Cthulhu programmer himself!
    • Skype
    • Steam
    • Twitter
Re: Lighting settings in game_settings.tbl
There is probably a middle ground there. Let mods define a min, max and default value and clamp the user preference to that if it exists.
This was the only suggestion I was gonna make. Looks good... or, well, wait, it looks like the default value is missing?

It seems to accept either a range or an override value, with no option to set a different default than the normal (beyond implicitly through the range clamping the regular default).
Ph'nglui mglw'nafh Codethulhu GitHub wgah'nagl fhtagn.

schrödinbug (noun) - a bug that manifests itself in running software after a programmer notices that the code should never have worked in the first place.

When you gaze long into BMPMAN, BMPMAN also gazes into you.

"I am one of the best FREDders on Earth" -General Battuta

<Aesaar> literary criticism is vladimir putin

<MageKing17> "There's probably a reason the code is the way it is" is a very dangerous line of thought. :P
<MageKing17> Because the "reason" often turns out to be "nobody noticed it was wrong".
(the very next day)
<MageKing17> this ****ing code did it to me again
<MageKing17> "That doesn't really make sense to me, but I'll assume it was being done for a reason."
<MageKing17> **** ME
<MageKing17> THE REASON IS PEOPLE ARE STUPID
<MageKing17> ESPECIALLY ME

<MageKing17> God damn, I do not understand how this is breaking.
<MageKing17> Everything points to "this should work fine", and yet it's clearly not working.
<MjnMixael> 2 hours later... "God damn, how did this ever work at all?!"
(...)
<MageKing17> so
<MageKing17> more than two hours
<MageKing17> but once again we have reached the inevitable conclusion
<MageKing17> How did this code ever work in the first place!?

<@The_E> Welcome to OpenGL, where standards compliance is optional, and error reporting inconsistent

<MageKing17> It was all working perfectly until I actually tried it on an actual mission.

<IronWorks> I am useful for FSO stuff again. This is a red-letter day!
* z64555 erases "Thursday" and rewrites it in red ink

<MageKing17> TIL the entire homing code is held up by shoestrings and duct tape, basically.

 

Offline m!m

  • 210
Re: Lighting settings in game_settings.tbl
Well, that proves that coding while being hungry does not work :nervous:
I'll fix it later.