Author Topic: Nightly (Windows): 03 Dec 2013 - Revision 10181  (Read 2119 times)

0 Members and 1 Guest are viewing this topic.

Offline SirKnightly

  • George or Keira?
  • 211
Nightly (Windows): 03 Dec 2013 - Revision 10181
Here is the nightly for Windows on 03 Dec 2013 - Revision 10181

Group: NO-SSE
fso-WIN-NO-SSE-20131203_r10181.7z
MD5Sum

Group: Standard
fso-WIN-Standard-20131203_r10181.7z
MD5Sum

Group: SSE
fso-WIN-SSE-20131203_r10181.7z
MD5Sum

Code: [Select]
------------------------------------------------------------------------
r10179 | Goober5000 | 2013-12-02 20:33:42 -0600 (Mon, 02 Dec 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missionparse.cpp

just make this block similar to the other one
------------------------------------------------------------------------
r10180 | Goober5000 | 2013-12-02 21:22:16 -0600 (Mon, 02 Dec 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missionparse.cpp

for wing names with hash symbols, put the ship number before the hash
------------------------------------------------------------------------
r10181 | Goober5000 | 2013-12-02 21:41:30 -0600 (Mon, 02 Dec 2013) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

when changing ship types, make sure the collision flags propagate
------------------------------------------------------------------------



 

Offline Nyctaeus

  • Betrayal is his middle name
  • 211
  • Your local priest of cheeki breeki!
    • Minecraft
    • Exile
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
My Avast found something called "Win32:Evo-gen [Susp]" and defined it as a virus or something. Is this something wrong, or just rare file or whatever?
Exile | Shadow Genesis | DA Profile | P3D Profile

Proud owner of NyctiShipyards. Remember - Nyx will fix it!

All of my assets including models, textures, skyboxes, effects may be used under standard CC BY-NC 4.0 license.

 

Offline niffiwan

  • 211
  • Eluder Class
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
Avast hates FSO.  With certain devs, it reckons the just-compiled-on-my-own-PC .exe's have viruses.  So, it's probably a false positive.
Creating a fs2_open.log | Red Alert Bug = Hex Edit | MediaVPs 2014: Bigger HUD gauges | 32bit libs for 64bit Ubuntu
----
Debian Packages (testing/unstable): Freespace2 | wxLauncher
----
m|m: I think I'm suffering from Stockholm syndrome. Bmpman is starting to make sense and it's actually written reasonably well...

 

Offline AdmiralRalwood

  • 211
  • The Cthulhu programmer himself!
    • Skype
    • Steam
    • Twitter
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
Avast hates FSO.  With certain devs, it reckons the just-compiled-on-my-own-PC .exe's have viruses.  So, it's probably a false positive.
To be fair, that is possible if the compiler is itself infected... not that that's likely in this case.

Also:
Code: [Select]
for wing names with hash symbols, put the ship number before the hash
How long has it been since that was first noticed? I can't find it on mantis...
Ph'nglui mglw'nafh Codethulhu GitHub wgah'nagl fhtagn.

schrödinbug (noun) - a bug that manifests itself in running software after a programmer notices that the code should never have worked in the first place.

When you gaze long into BMPMAN, BMPMAN also gazes into you.

"I am one of the best FREDders on Earth" -General Battuta

<Aesaar> literary criticism is vladimir putin

<MageKing17> "There's probably a reason the code is the way it is" is a very dangerous line of thought. :P
<MageKing17> Because the "reason" often turns out to be "nobody noticed it was wrong".
(the very next day)
<MageKing17> this ****ing code did it to me again
<MageKing17> "That doesn't really make sense to me, but I'll assume it was being done for a reason."
<MageKing17> **** ME
<MageKing17> THE REASON IS PEOPLE ARE STUPID
<MageKing17> ESPECIALLY ME

<MageKing17> God damn, I do not understand how this is breaking.
<MageKing17> Everything points to "this should work fine", and yet it's clearly not working.
<MjnMixael> 2 hours later... "God damn, how did this ever work at all?!"
(...)
<MageKing17> so
<MageKing17> more than two hours
<MageKing17> but once again we have reached the inevitable conclusion
<MageKing17> How did this code ever work in the first place!?

<@The_E> Welcome to OpenGL, where standards compliance is optional, and error reporting inconsistent

<MageKing17> It was all working perfectly until I actually tried it on an actual mission.

<IronWorks> I am useful for FSO stuff again. This is a red-letter day!
* z64555 erases "Thursday" and rewrites it in red ink

<MageKing17> TIL the entire homing code is held up by shoestrings and duct tape, basically.

 

Offline Goober5000

  • HLP Loremaster
  • Administrator
  • 214
    • Goober5000 Productions
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
Quote
Code: [Select]
for wing names with hash symbols, put the ship number before the hash
How long has it been since that was first noticed? I can't find it on mantis...

I first noticed when I was FREDding ST:R, but I only just now got around to fixing it.  It's not in Mantis that I know of.

 
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
Quote
Code: [Select]
for wing names with hash symbols, put the ship number before the hash
How long has it been since that was first noticed? I can't find it on mantis...

I first noticed when I was FREDding ST:R, but I only just now got around to fixing it.  It's not in Mantis that I know of.

Please  note that this will break Blue Planet's The blade itself mission which uses Katana# As the wing name to hide the 1 which appears due to the player being a frigate
May the Force be with you

 

Offline Goober5000

  • HLP Loremaster
  • Administrator
  • 214
    • Goober5000 Productions
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
Uh... if the player is in a wing, why shouldn't his number be visible?

Okay, I think I know why this is done.  The player always has to be in a starting wing, so they used Katana# as the starting wing, rather than Alpha or whatever.

Bear in mind that this fix is needed for the much more common case where a wing departs and later re-appears.  (I got around this in ST:R, but it was clunky.)  Could you attach the mission in question?

 
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
It's already included in WIH but here it is anyway.

[attachment deleted by an evil time traveler]
May the Force be with you

 

Offline Goober5000

  • HLP Loremaster
  • Administrator
  • 214
    • Goober5000 Productions
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
Okay.  I think what I'll do is change things so that the fix is only applied if the hash symbol isn't the last character.

 
Re: Nightly (Windows): 03 Dec 2013 - Revision 10181
That seems logical.
May the Force be with you